bootresource.poll and .fetch methods double json-encode result
Bug #1959183 reported by
Alberto Donato
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Alberto Donato | ||
Bug Description
The bootresource.poll and bootresource.fetch websocket handlers return a string as result, with json content.
They should instead return a regular list/dict so that json encoding happens automatically for the whole response in the base handler.
Related branches
~ack/maas:1959183-bootresource-ws-no-double-json
- MAAS Lander: Needs Fixing
- Adam Collard (community): Approve
-
Diff: 653 lines (+104/-163)2 files modifiedsrc/maasserver/websockets/handlers/bootresource.py (+40/-45)
src/maasserver/websockets/handlers/tests/test_bootresource.py (+64/-118)
| Changed in maas: | |
| status: | New → Triaged |
Revision history for this message
| Alberto Donato (ack) wrote | #1 |
| Changed in maas: | |
| status: | Triaged → In Progress |
| tags: | added: ui |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | next → 3.2.0-beta1 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Added a ui tag as the UI side will need to remove the extra json decoding