Line dashing all but two display continues line

[grofaty]

Pinta/master and Pinta/2.0.2 on Ubuntu 20.04.

1. Select Line/Curve and change Brush width to 30, to easily follow.
2. Draw line and select Dash first one. Works as expected solid line
3. Now use other dashes and all but two are actually dashed lines, others are solid lines.

I remember this was working fine not so long ago. See attachment.

[Cameron White (cameronwhite91)]

Testing on Pinta 1.7 this behaves the same, so at least it's not a GTK3 bug ..

[Cameron White (cameronwhite91)]

Looking into the issues with dashes, this broke from the changes for bug 1922470

The different line cap styles have quite different behaviour in combination with dashes (https://www.cairographics.org/manual/cairo-cairo-t.html#cairo-set-dash), e.g. a length of 0.0 can actually draw a square

We could either find an alternative fix for the previous issue, or adjust how the dash patterns are translated to cairo to accommodate the line cap style.

[grofaty (grofaty)]

May I suggest to temporally remove all of the non-working dashes from menu and release Pinta 2.1.
Probably after Pinta 2.1 release, when we figure it out how to fix this problem, then re-add them to menu again.

[Cameron White (cameronwhite91)]

Should be fixed by https://github.com/PintaProject/Pinta/commit/7e159d60d8987505918c8254952d1bf850f580fc and prior commits

[grofaty (grofaty)]

I tested latest Pinta 2.1-dev on Ubuntu 22.10 and I see this dashing problem fixed.

Just a little note. What I see now is when rectangle is drawn, mouse released and moved away from object, and move mouse back to rectangle edge and now arrow icon appears. Before this merge it was hand icon. Actually I like this tip arrow point mouse icon more, because it more precisely determinants where exactly rectangle is going to be curved (at tip point of point arrow).