[ovn]Refusing to bind port to dead agent

[ZhouHeng]

When the driver of ML2 is configured as ovs, if the agent status is not alive, the binding port will be refused.

However, when ovn is used as the driver of ML2, it can bind normally, and the portt be active, and it is easy to create a virtual machine and wait for network-vif-plugged timeout

we should refuse to bind port to dead agent

[Oleg Bondarev (obondarev)]

Fix: https://review.opendev.org/c/openstack/neutron/+/825428

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/825428
Committed: https://opendev.org/openstack/neutron/commit/8a55f091925fd5e6742fb92783c524450843f5a0
Submitter: "Zuul (22348)"
Branch: master

commit 8a55f091925fd5e6742fb92783c524450843f5a0
Author: zhouhenglc <email address hidden>
Date: Thu Jan 20 15:09:32 2022 +0800

    [ovn]Refusing to bind port to dead agent

    Closes-bug: #1958501

    Change-Id: Ia84410675d28002afc74368349c9b54f048f4f4d

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/844494

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/844494
Committed: https://opendev.org/openstack/neutron/commit/267631e8fb35af4d9d96c70c6e6ddba25256f195
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 267631e8fb35af4d9d96c70c6e6ddba25256f195
Author: zhouhenglc <email address hidden>
Date: Thu Jan 20 15:09:32 2022 +0800

    [ovn]Refusing to bind port to dead agent

    Closes-bug: #1958501

    Conflicts:
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py
        neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py

    Change-Id: Ia84410675d28002afc74368349c9b54f048f4f4d
    (cherry picked from commit 8a55f091925fd5e6742fb92783c524450843f5a0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 20.2.0 release.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/853479

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/853479
Committed: https://opendev.org/openstack/neutron/commit/eda45de8391597b6f29d76715996755cb1777dd0
Submitter: "Zuul (22348)"
Branch: master

commit eda45de8391597b6f29d76715996755cb1777dd0
Author: Slawek Kaplonski <email address hidden>
Date: Wed Aug 17 14:00:33 2022 +0200

    [OVN] Try to bind ports only to the ovn-controller agents

    Patch [1] added getting ovn agents from the agents cache and check
    if agent is alive to bound port to it.
    Small issue with it was that it could check e.g. ovn metadata agent from
    the host as it was only filtering agents by the host on which they are.

    This patch adds filter on the agent_type so only ovn-controller agents
    are taken from the cache.

    [1] https://review.opendev.org/c/openstack/neutron/+/825428

    Related-Bug: #1958501
    Change-Id: If065204d7521c480656a22fb078bbe6273b5fc70

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/neutron/+/853635

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/853635
Committed: https://opendev.org/openstack/neutron/commit/601b01f82b6fcaa699eda556c8094208fd20f10b
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 601b01f82b6fcaa699eda556c8094208fd20f10b
Author: Slawek Kaplonski <email address hidden>
Date: Wed Aug 17 14:00:33 2022 +0200

    [OVN] Try to bind ports only to the ovn-controller agents

    Patch [1] added getting ovn agents from the agents cache and check
    if agent is alive to bound port to it.
    Small issue with it was that it could check e.g. ovn metadata agent from
    the host as it was only filtering agents by the host on which they are.

    This patch adds filter on the agent_type so only ovn-controller agents
    are taken from the cache.

    [1] https://review.opendev.org/c/openstack/neutron/+/825428

    Related-Bug: #1958501
    Change-Id: If065204d7521c480656a22fb078bbe6273b5fc70
    (cherry picked from commit eda45de8391597b6f29d76715996755cb1777dd0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 21.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/901023

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/neutron/+/901024

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/901025

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/901026

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901023
Committed: https://opendev.org/openstack/neutron/commit/461d30debca10b2e04a764ac6203485d95dff3ee
Submitter: "Zuul (22348)"
Branch: stable/xena

commit 461d30debca10b2e04a764ac6203485d95dff3ee
Author: zhouhenglc <email address hidden>
Date: Thu Jan 20 15:09:32 2022 +0800

    [ovn]Refusing to bind port to dead agent

    Closes-bug: #1958501

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py
        neutron/tests/unit/fake_resources.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Change-Id: Ia84410675d28002afc74368349c9b54f048f4f4d
    (cherry picked from commit 8a55f091925fd5e6742fb92783c524450843f5a0)
    (cherry picked from commit 267631e8fb35af4d9d96c70c6e6ddba25256f195)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901024
Committed: https://opendev.org/openstack/neutron/commit/c51d6d117af4c739106903f5a525b82434893cff
Submitter: "Zuul (22348)"
Branch: stable/xena

commit c51d6d117af4c739106903f5a525b82434893cff
Author: Slawek Kaplonski <email address hidden>
Date: Wed Aug 17 14:00:33 2022 +0200

    [OVN] Try to bind ports only to the ovn-controller agents

    Patch [1] added getting ovn agents from the agents cache and check
    if agent is alive to bound port to it.
    Small issue with it was that it could check e.g. ovn metadata agent from
    the host as it was only filtering agents by the host on which they are.

    This patch adds filter on the agent_type so only ovn-controller agents
    are taken from the cache.

    [1] https://review.opendev.org/c/openstack/neutron/+/825428

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Related-Bug: #1958501
    Change-Id: If065204d7521c480656a22fb078bbe6273b5fc70
    (cherry picked from commit eda45de8391597b6f29d76715996755cb1777dd0)
    (cherry picked from commit 601b01f82b6fcaa699eda556c8094208fd20f10b)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901025
Committed: https://opendev.org/openstack/neutron/commit/3bf58e9a133498050c75b67e7d3732390d3e9f30
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 3bf58e9a133498050c75b67e7d3732390d3e9f30
Author: zhouhenglc <email address hidden>
Date: Thu Jan 20 15:09:32 2022 +0800

    [ovn]Refusing to bind port to dead agent

    Closes-bug: #1958501

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/agent/neutron_agent.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py
        neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py
        neutron/tests/unit/fake_resources.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Change-Id: Ia84410675d28002afc74368349c9b54f048f4f4d
    (cherry picked from commit 8a55f091925fd5e6742fb92783c524450843f5a0)
    (cherry picked from commit 267631e8fb35af4d9d96c70c6e6ddba25256f195)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/901026
Committed: https://opendev.org/openstack/neutron/commit/f28f6b01e19200c9502bce14581d1e538f27dd05
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit f28f6b01e19200c9502bce14581d1e538f27dd05
Author: Slawek Kaplonski <email address hidden>
Date: Wed Aug 17 14:00:33 2022 +0200

    [OVN] Try to bind ports only to the ovn-controller agents

    Patch [1] added getting ovn agents from the agents cache and check
    if agent is alive to bound port to it.
    Small issue with it was that it could check e.g. ovn metadata agent from
    the host as it was only filtering agents by the host on which they are.

    This patch adds filter on the agent_type so only ovn-controller agents
    are taken from the cache.

    [1] https://review.opendev.org/c/openstack/neutron/+/825428

    Conflicts:
        neutron/plugins/ml2/drivers/ovn/mech_driver/mech_driver.py
        neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/test_mech_driver.py

    Related-Bug: #1958501
    Change-Id: If065204d7521c480656a22fb078bbe6273b5fc70
    (cherry picked from commit eda45de8391597b6f29d76715996755cb1777dd0)
    (cherry picked from commit 601b01f82b6fcaa699eda556c8094208fd20f10b)
    (cherry picked from commit 6cc5adac709a82616529cd1599fd4ce8add2da84)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron wallaby-eom release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron xena-eom release.