Bootstrap Opac: Request a Card link displays regardless of the Self-Registration library setting

[Garry Collum]

EG 3.8.0 and current master

The 'Request a Card' link displays on the login page and in the login modal of the Bootstrap Opac regardless of the 'Allow Patron Self-Registration' library setting.

[Garry Collum (gcollum)]

A proposed fix is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gcollum/lp1958163_bootstrap_opac_request_a_card_link

[Andrea Neiman (aneiman)]

Tried this on pattypan and it does not appear to be working for me - I still see the "request card" link in both Firefox & Chrome even with the Library Setting set to False, even after a hard refresh of the OPAC.

I'm not removing the pullrequest tag because I will note that this test server also has the Library Settings Angular port (bug 1839341) on it and I'm not sure whether that's intersecting.

For now I have left the Library Setting at false on pattypan if anyone else wants to take a look.

[Terran McCanna (tmccanna)]

I saw the same behavior that Andrea did on the pattypan test server so I added it to terran-testbox and it is working there.

Setting blank (default): Link does not show
Setting true: Link appears
Setting false: Link does not show

(Note that this setting controls whether the link appears in the footer navbar as well - that is also broken on pattypan with the work for bug 1839341 applied.)

[Terran McCanna (tmccanna)]

As it is working on straight master without bug 1839341, I've signed off here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna
/lp1958163_bootstrap_opac_request_a_card_link_signoff

[Jane Sandberg (sandbergja)]

This fix works well for me. Thanks, Garry and Terran. Pushed to 3.8 and above.