deployment doesn't fail if ntp servers are unavailable

[Alex Schultz]

Prior to using chrony we would fail if the ntp servers were unavailable.

https://github.com/openstack/tripleo-heat-templates/blob/queens-eol/puppet/services/time/ntp.yaml#L99-L100

This was broken by a change from waitsync to makestep https://review.opendev.org/c/openstack/tripleo-heat-templates/+/712981

Because NTP is a hard requirement for the deployment to properly work, we need to make sure that we fail if ntp servers are unavailable.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822330
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/8d46c9c381a2487d759f477948eabe51d40479b7
Submitter: "Zuul (22348)"
Branch: master

commit 8d46c9c381a2487d759f477948eabe51d40479b7
Author: Alex Schultz <email address hidden>
Date: Mon Dec 20 07:58:27 2021 -0700

    Add chrony waitsync back in

    This is a revert of 373a27163e0365919f707604df5b61863029d2e4 because
    makestep does not fail if the ntp servers are unavailable. This change
    adds waitsync back in so it fails if the servers are unavilable but
    leaves the makestep in place which should force the sync. If the
    servers are unavailable, the waitsync should catch it. If they are
    available waitsync should be a relative noop because the makestep would
    sync the system. The waitsync has been increased to 5 minutes (from 200
    seconds). waitsync will wait 30 times with an interval of 10 seconds
    between checks.

    Closes-Bug: #1955414
    Change-Id: I4ac9210f6533e6826b2814f72b7271b43fdca267

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822428

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822429

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822510

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822428
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/5341e56992b5b3c1c7e7813801fe5a27ae1e4d98
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5341e56992b5b3c1c7e7813801fe5a27ae1e4d98
Author: Alex Schultz <email address hidden>
Date: Mon Dec 20 07:58:27 2021 -0700

    Add chrony waitsync back in

    This is a revert of 373a27163e0365919f707604df5b61863029d2e4 because
    makestep does not fail if the ntp servers are unavailable. This change
    adds waitsync back in so it fails if the servers are unavilable but
    leaves the makestep in place which should force the sync. If the
    servers are unavailable, the waitsync should catch it. If they are
    available waitsync should be a relative noop because the makestep would
    sync the system. The waitsync has been increased to 5 minutes (from 200
    seconds). waitsync will wait 30 times with an interval of 10 seconds
    between checks.

    Depends-On: https://review.opendev.org/c/openstack/ansible-role-collect-logs/+/822848
    Depends-On: https://review.opendev.org/c/openstack/tripleo-ci/+/822857
    Closes-Bug: #1955414
    Change-Id: I4ac9210f6533e6826b2814f72b7271b43fdca267
    (cherry picked from commit 8d46c9c381a2487d759f477948eabe51d40479b7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822510
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/69f283014f7e9b6ec252a96986f8bb68fe16b023
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 69f283014f7e9b6ec252a96986f8bb68fe16b023
Author: Alex Schultz <email address hidden>
Date: Mon Dec 20 07:58:27 2021 -0700

    Add chrony waitsync back in

    This is a revert of 373a27163e0365919f707604df5b61863029d2e4 because
    makestep does not fail if the ntp servers are unavailable. This change
    adds waitsync back in so it fails if the servers are unavilable but
    leaves the makestep in place which should force the sync. If the
    servers are unavailable, the waitsync should catch it. If they are
    available waitsync should be a relative noop because the makestep would
    sync the system. The waitsync has been increased to 5 minutes (from 200
    seconds). waitsync will wait 30 times with an interval of 10 seconds
    between checks.

    Closes-Bug: #1955414
    Change-Id: I4ac9210f6533e6826b2814f72b7271b43fdca267
    (cherry picked from commit 8d46c9c381a2487d759f477948eabe51d40479b7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822429
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/fc293280c25e57d778bd79be1e95c76309ef2a3f
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit fc293280c25e57d778bd79be1e95c76309ef2a3f
Author: Alex Schultz <email address hidden>
Date: Mon Dec 20 07:58:27 2021 -0700

    Add chrony waitsync back in

    This is a revert of 373a27163e0365919f707604df5b61863029d2e4 because
    makestep does not fail if the ntp servers are unavailable. This change
    adds waitsync back in so it fails if the servers are unavilable but
    leaves the makestep in place which should force the sync. If the
    servers are unavailable, the waitsync should catch it. If they are
    available waitsync should be a relative noop because the makestep would
    sync the system. The waitsync has been increased to 5 minutes (from 200
    seconds). waitsync will wait 30 times with an interval of 10 seconds
    between checks.

    Closes-Bug: #1955414
    Change-Id: I4ac9210f6533e6826b2814f72b7271b43fdca267
    (cherry picked from commit 8d46c9c381a2487d759f477948eabe51d40479b7)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/822511
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/301794e61add9dc7cd3d75cc76c370e54da198da
Submitter: "Zuul (22348)"
Branch: stable/train

commit 301794e61add9dc7cd3d75cc76c370e54da198da
Author: Alex Schultz <email address hidden>
Date: Mon Dec 20 07:58:27 2021 -0700

    Add chrony waitsync back in

    This is a revert of 373a27163e0365919f707604df5b61863029d2e4 because
    makestep does not fail if the ntp servers are unavailable. This change
    adds waitsync back in so it fails if the servers are unavilable but
    leaves the makestep in place which should force the sync. If the
    servers are unavailable, the waitsync should catch it. If they are
    available waitsync should be a relative noop because the makestep would
    sync the system. The waitsync has been increased to 5 minutes (from 200
    seconds). waitsync will wait 30 times with an interval of 10 seconds
    between checks.

    Closes-Bug: #1955414
    Change-Id: I4ac9210f6533e6826b2814f72b7271b43fdca267
    (cherry picked from commit 8d46c9c381a2487d759f477948eabe51d40479b7)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.4.6 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 16.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 13.6.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.