kube-apiserver-change-params template misses logging and error handling

[Rafael Lucas Camargos]

Brief Description
-----------------
The kube-apiserver-change-params template has no logging and no error handling. It should be rewritten as either a puppet class or an ansible playbook.

Severity
--------
Minor

Steps to Reproduce
------------------
To trigger the kube-apiserver-change-params script one can use the following:

system service-parameter-add kubernetes kube_apiserver oidc_client_id=stx-oidc-client-app
system service-parameter-add kubernetes kube_apiserver oidc_issuer_url=https://10.10.10.3:30556/dex
system service-parameter-add kubernetes kube_apiserver oidc_username_claim=email
system service-parameter-add kubernetes kube_apiserver oidc_groups_claim=group
system service-parameter-apply kubernetes

Expected Behavior
------------------
Logs and error handling should happen

Actual Behavior
----------------
No logs and no error handling is done

Reproducibility
---------------
100%

System Configuration
--------------------
Any

Branch/Pull Time/Commit
-----------------------
2021-12-20

Last Pass
---------
N/A

Timestamp/Logs
--------------
N/A

Test Activity
-------------
Developer Testing

Workaround
----------
N/A

[Ghada Khalil (gkhalil)]

This was raised as a comment in this review: https://review.opendev.org/c/starlingx/stx-puppet/+/821622

[Ghada Khalil (gkhalil)]

screening: low / not gating; code cleanup