"LoggingPlugin._clean_logs_by_target_id" failing in stable releases

Bug #1954666 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Rodolfo Alonso

Bug Description

Method "LoggingPlugin._clean_logs_by_target_id" is failing in stable released. This method was added in [1] and backported up to Train.

The problem here is that the PORT notifications (event AFTER_DELETE) use "DBEventPayload" since Xena. From Train to Wallaby, the PORT notifications use the old format: the arguments are passed as kwargs.

[1]https://review.opendev.org/q/Icb92327a06486e168ce064532d819347e6031cc1

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
importance: Undecided → High
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/821563

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/821564

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/821565

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/821566

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/821563
Committed: https://opendev.org/openstack/neutron/commit/aaa0e99bacabe8d97f7090f42c21b3a80bf6d384
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit aaa0e99bacabe8d97f7090f42c21b3a80bf6d384
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Dec 13 13:53:47 2021 +0000

    [stable-only] "_clean_logs_by_target_id" to use old notifications

    "LoggingPlugin._clean_logs_by_resource_id" method receives PORT,
    AFTER_DELETE events, in the old format (not using payloads but
    kwargs). New implementation was added in Xena release.

    Closes-Bug: #1954666
    Change-Id: I736fef3a10bc2887efb26c95e9fc1eea14969ccf

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/821564
Committed: https://opendev.org/openstack/neutron/commit/c68ce94f014549f46094e67a2fba92676522dd21
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit c68ce94f014549f46094e67a2fba92676522dd21
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Dec 13 13:53:47 2021 +0000

    [stable-only] "_clean_logs_by_target_id" to use old notifications

    "LoggingPlugin._clean_logs_by_resource_id" method receives PORT,
    AFTER_DELETE events, in the old format (not using payloads but
    kwargs). New implementation was added in Xena release.

    Closes-Bug: #1954666
    Change-Id: I736fef3a10bc2887efb26c95e9fc1eea14969ccf
    (cherry picked from commit aaa0e99bacabe8d97f7090f42c21b3a80bf6d384)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/821565
Committed: https://opendev.org/openstack/neutron/commit/d384849918218ece9ed3d3a0835d21f8c7a481b8
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit d384849918218ece9ed3d3a0835d21f8c7a481b8
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Dec 13 13:53:47 2021 +0000

    [stable-only] "_clean_logs_by_target_id" to use old notifications

    "LoggingPlugin._clean_logs_by_resource_id" method receives PORT,
    AFTER_DELETE events, in the old format (not using payloads but
    kwargs). New implementation was added in Xena release.

    Closes-Bug: #1954666
    Change-Id: I736fef3a10bc2887efb26c95e9fc1eea14969ccf
    (cherry picked from commit aaa0e99bacabe8d97f7090f42c21b3a80bf6d384)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/821566
Committed: https://opendev.org/openstack/neutron/commit/72c00f108ed45289ae75e53685bf2250d898a397
Submitter: "Zuul (22348)"
Branch: stable/train

commit 72c00f108ed45289ae75e53685bf2250d898a397
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Dec 13 13:53:47 2021 +0000

    [stable-only] "_clean_logs_by_target_id" to use old notifications

    "LoggingPlugin._clean_logs_by_resource_id" method receives PORT,
    AFTER_DELETE events, in the old format (not using payloads but
    kwargs). New implementation was added in Xena release.

    Closes-Bug: #1954666
    Change-Id: I736fef3a10bc2887efb26c95e9fc1eea14969ccf
    (cherry picked from commit aaa0e99bacabe8d97f7090f42c21b3a80bf6d384)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.3.0

This issue was fixed in the openstack/neutron 17.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.2.0

This issue was fixed in the openstack/neutron 18.2.0 release.

Changed in neutron:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron train-eol

This issue was fixed in the openstack/neutron train-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron ussuri-eol

This issue was fixed in the openstack/neutron ussuri-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.