Support ACQ Advanced Shipment Notices (DESADV -- Dispatch Advice Messages)

Bug #1952931 reported by Bill Erickson
26
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Evergreen 3.8 / Wishlist

Here's the basic work flow:

1. One more more orders placed with a vendor

2. Vendor packs and ships one or more items across one or more lineitems and purchase orders

3. Vendor generates a DESADV EDI message to describe the package.

It contains:

- Dispatched POs', lineitems, and the number of items per lineitem.

- A package-level barcode (e.g. https://en.wikipedia.org/wiki/Serial_shipping_container_code) that represents the package as a whole. AKA the "super barcode"

4. EG retrieves the EDI and stores the extracted data in a new table, including the super barcode and the affected PO's, etc.

5. Package arrives with a super barcode.

6. Staff scan the super barcode in a new ACQ UI which pulls up info on the affected items. This UI can be made to auto-receive, request receive confirmation, link to individual items for item-specific tasks, etc.

7. Once received, all affected items are marked as received and staff no longer needs to manually receive individual items.

===

The spec:

https://www.editeur.org/files/EDIfact%20eancom%20pdfs/EDIfact%20trade%20book%20supply/061030%20T7%20DESADV%20(despatch%20advice%20v%201.2).pdf

Revision history for this message
Bill Erickson (berick) wrote :

Branch here:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1952931-acq-asn-v2

* Supports loading / parsing DESADV EDI messages and creating acq.shipment_notification entries
* UI for scanning super-barcodes, displaying shipment notification contents, and batch receiving.
* Includes Per live test

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
milestone: none → 3.9-beta
tags: added: pullrequest
Revision history for this message
Blake GH (bmagic) wrote :

This patch doesn't merge onto master at the moment. Can't merge for bug squashing week.

tags: added: needswork
removed: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Blake. Here's a new one:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1952931-acq-asn-v3

Just a reminder this is built atop the code for bug #1942220

Revision history for this message
Bill Erickson (berick) wrote :

Just found a few more issues that need fixing. Code in progress.

Bill Erickson (berick)
Changed in evergreen:
milestone: 3.9-beta → 3.next
Revision history for this message
Bill Erickson (berick) wrote :
Revision history for this message
Bill Erickson (berick) wrote :

Just a note we are using this in production with B&T. Other vendors may be supported soon.

Changed in evergreen:
milestone: 3.next → 3.10-beta
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Tiffany Little (tslittle) wrote :

I'm not sure about technically signing off on this because I haven't tested because EDI is so difficult to test on a stock server. However, Bill did a presentation for for the Acq Interest Group on this feature, and mentioned that it is completely optional. With that in mind, I would like to advocate for this going into 3.10 (pending a rebase) so that it can start to be used in production environments and uncover any necessary follow-up bugfixes.

Revision history for this message
Bill Erickson (berick) wrote :

Rebased branch pushed, which includes changes to support Ingram ASN messages.

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1952931-acq-asn-v5

Reminder that this is built atop bug #1942220 and requires that branch be merged first -- Only the LP1952931 commits from this branch should be merged once bug #1942220 is merged.

tags: removed: needswork
Michele Morgan (mmorgan)
tags: added: pullrequest
Revision history for this message
Jane Sandberg (sandbergja) wrote :
Revision history for this message
Tiffany Little (tslittle) wrote :

I pulled this onto my server to test as best I can, and I also went back to the recording of the AIG September meeting when you demoed this, Bill, to try to familiarize myself with it as much as possible since I don't have data to test it with.

One thing I see is missing is the admin menu item for the Shipment Notification grid. Even when I try to go to admin/server/acq/shipment_notification I get console errors. Should that already be here in this branch, or is it missing?

Revision history for this message
Bill Erickson (berick) wrote :

Tiffany, the main entry point for managing ASN is under the Acquisitions menu => Receive Shipment

You can see raw ASN data at /eg2/staff/admin/acq/shipment_notification, though this is only a side effect of how these URLs are auto-generated. It's not meant to be a staff-facing interface -- not yet, anyway. Regardless, there should not be any console errors. Console errors suggest a build/deployment issue. What kind of errors are you seeing?

Revision history for this message
Tiffany Little (tslittle) wrote :

Ah, I see. The raw ASN data was what I was searching for and not finding. I reloaded the branch on my server again and I'm not getting the console error anymore, so that's on me.

With what testing I'm able to do without EDI data and setup with the vendors, all looks fine to me. I didn't notice anything untoward. So I will officially signoff.

I have tested this code and consent to signing off on it with my name, Tiffany Little, and my email address, <email address hidden>.

tags: added: signedoff
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbergja)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Bill and Tiffany! Merged for inclusion in 3.10.

Changed in evergreen:
assignee: Jane Sandberg (sandbergja) → nobody
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.