convert_v1_net_data.py - ipv6: true/false is migrated under the subnet, it should be at network level.

[Harald Jensås]

convert_v1_net_data.py - ipv6: true/false is migrated under the subnet, it should be at network level.

- name: FooFoo
  name_lower: foo_bar
  ipv6: true
  vip: true
  vlan: 30
  ip_subnet: '172.16.1.0/24'
  allocation_pools: [{'start': '172.16.1.4', 'end': '172.16.1.250'}]
  ipv6_subnet: 'fd00:fd00:fd00:3000::/64'
  ipv6_allocation_pools: [{'start': 'fd00:fd00:fd00:3000::10', 'end': 'fd00:fd00:fd00:3000:ffff:ffff:ffff:fffe'}]
  mtu: 1500

converts to:

- name: FooFoo
  name_lower: foo_bar
  vip: true
  mtu: 1500
  subnets:
    foo_bar_subnet:
      ipv6: true <--- WRONG
      vlan: 30
      ip_subnet: 172.16.1.0/24
      allocation_pools:
      - start: 172.16.1.4
        end: 172.16.1.250
      ipv6_subnet: fd00:fd00:fd00:3000::/64
      ipv6_allocation_pools:
      - start: fd00:fd00:fd00:3000::10
        end: fd00:fd00:fd00:3000:ffff:ffff:ffff:fffe

Should convert to:
- name: FooFoo
  name_lower: foo_bar
  vip: true
  mtu: 1500
  ipv6: true <--- CORRECT
  subnets:
    foo_bar_subnet:
      vlan: 30
      ip_subnet: 172.16.1.0/24
      allocation_pools:
      - start: 172.16.1.4
        end: 172.16.1.250
      ipv6_subnet: fd00:fd00:fd00:3000::/64
      ipv6_allocation_pools:
      - start: fd00:fd00:fd00:3000::10
        end: fd00:fd00:fd00:3000:ffff:ffff:ffff:fffe

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818287

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818287
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/531aecc4ba8410f609b6be9a99eae01ad37a52eb
Submitter: "Zuul (22348)"
Branch: master

commit 531aecc4ba8410f609b6be9a99eae01ad37a52eb
Author: Harald Jensås <email address hidden>
Date: Wed Nov 17 21:41:00 2021 +0100

    Fix convert_v1_net_data.py - ipv6 property

    Ensure the ipv6 property is at the network level.
    Previously the key would be converted in at the
    subnet level, which is incorrect.

    Closes-Bug: #1951308
    Change-Id: Iab58ff31b4434785376ae3c553c0e7c89c6b7ff5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818737

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/818737
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/4b2da32572aac0b8de57e9e58d7ef25e310aee92
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4b2da32572aac0b8de57e9e58d7ef25e310aee92
Author: Harald Jensås <email address hidden>
Date: Wed Nov 17 21:41:00 2021 +0100

    Fix convert_v1_net_data.py - ipv6 property

    Ensure the ipv6 property is at the network level.
    Previously the key would be converted in at the
    subnet level, which is incorrect.

    Closes-Bug: #1951308
    Change-Id: Iab58ff31b4434785376ae3c553c0e7c89c6b7ff5
    (cherry picked from commit 531aecc4ba8410f609b6be9a99eae01ad37a52eb)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 16.0.0 release.