Angular Action/Trigger Event Definition screen clone dialog buttons should be re-labeled

[Jane Sandberg]

In the new Angular Action/Trigger Event Definition grid, you can clone an event definition by selecting it, then selecting "Clone selected" from the actions menu.

This brings up a dialog asking whether or not you'd like to bring the environment along with you. It gives two options -- not "Yes" and "No", which would make more sense, but "OK" and "Cancel". "OK" has the effect of bringing the environment, while "Cancel" proceeds with the clone, but does not clone the environment.

I'd recommend that the buttons be relabeled from "OK" to "Yes" and "Cancel" to "No", to better describe the outcome of clicking the button. It could also be nice to have an actual "Cancel" button that stops the cloning process on this modal.

[Shula Link (slink-g)]

Looking at the code, it looks like that dialog is linked to the eg-confirm-dialog component (Open-ILS/src/eg2/src/app/share/dialog/comfirm.component.ts). I'm not sure, but I think using an eg-dialog component (.../dialog.component.ts) might allow the desired functionality, if there's an observable that can be passed. Even then, it only allows for two options that I see.

[Stephanie Leary (stephanieleary)]

Patch, largely written by Galen: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=a581623b2cfd56d072a1c3b00ad138811a448d50

We'd appreciate feedback on whether you agree with this decision to duplicate the code between the confirm and prompt components rather than placing it in the dialog component.