[MIR] libio-interactive-perl

[Lukas Märdian]

[Availability]
The package libio-interactive-perl is already in Ubuntu universe.
The package libio-interactive-perl builds for the architectures it is designed to work on.
It currently builds and works for architectures: <all> (perl package)
Link to package [[https://launchpad.net/ubuntu/+source/libio-interactive-perl]]

[Rationale]
- The package libio-interactive-perl is required in Ubuntu main for licensecheck
 - The package libio-interactive-perl will not generally be useful for a large part of
   our user base, but is important/helpful still because it is a requirement for licensecheck
- The package libio-interactive-perl is a new runtime dependency of package licensecheck (starting with 3.2.0-1) that
  we already support

[Security]
- No CVEs/security issues in this software in the past

- no `suid` or `sgid` binaries (it's a Perl library)
- no executables in `/sbin` and `/usr/sbin` (it's a Perl library)
- Package does not install services
- Packages does not open privileged ports (ports < 1024)
- Packages does not contain extensions to security-sensitive software
  (filters, scanners, plugins, UI skins, ...)

[Quality assurance - function/usage]
- The package works well right after install

[Quality assurance - maintenance]
- The upstream appears to be somewhat active and the package is maintained by
  the Debian perl team.
- The package has no long term critical bugs open
 - Ubuntu https://bugs.launchpad.net/ubuntu/+source/libio-interactive-perl/+bug
 - Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=libio-interactive-perl
- The package does not deal with exotic hardware we cannot support

[Quality assurance - testing]
- The package runs a test suite on build time, if it fails
  it makes the build fail, link to build log
https://launchpadlibrarian.net/536120852/buildlog_ubuntu-impish-amd64.libio-interactive-perl_1.023-1_BUILDING.txt.gz

- The package runs an autopkgtest, and is currently passing on
  this amd64 list of architectures, link to test logs
https://launchpadlibrarian.net/536120852/buildlog_ubuntu-impish-amd64.libio-interactive-perl_1.023-1_BUILDING.txt.gz
- The package declares the autopkgtest-pkg-perl test-suite.
- The package does have no failing autopkgtests right now

[Quality assurance - packaging]
- debian/watch is present and works

- This package does not yield massive lintian Warnings, Errors
- Lintian overrides are not present
- Output of lintian --pedantic:
  W: libio-interactive-perl: changelog-distribution-does-not-match-changes-file (unstable != jammy)
  W: libio-interactive-perl changes: distribution-and-changes-mismatch jammy unstable

- This package does not rely on obsolete or about to be demoted packages.
- This package has no python2 or GTK2 dependencies

- The package will be installed by default, but does not ask debconf
  questions higher than medium

- Packaging and build is easy.
- Content of d/rules:
  #!/usr/bin/make -f

  %:
   dh $@

[UI standards]
- Application is not end-user facing (does not need translation)

[Dependencies]
- No further depends or recommends dependencies that are not yet in main

[Standards compliance]
- This package correctly follows FHS and Debian Policy
- Only concern is a warning reported by lintian --pedantic:
  W: libio-interactive-perl: changelog-distribution-does-not-match-changes-file (unstable != jammy)
  W: libio-interactive-perl changes: distribution-and-changes-mismatch jammy unstable

[Maintenance/Owner]
- Owning Team will be Foundations team (to be confirmed)
 - Team is not yet, but will subscribe to the package before promotion

- This does not use static builds
- This does not use vendored code

[Background information]
The Package description explains the package well
Upstream Name is IO-Interactive
Link to upstream project https://metacpan.org/dist/IO-Interactive

[Christian Ehrhardt  (paelzer)]

Review for Package: libio-interactive-perl

[Summary]
MIR team ACK

This package is very small, well maintained, does not seem to need a lot of
attention. And with 4 autopkgtest and 16 build time tests for - after
subtracting the boilerplate - mabye 60 lines of code it is also well covered.
Imagine that ratio of 1 test per 3 LOC for every project.

This does not need a security review

List of specific binary packages to be promoted to main: libio-interactive-perl
Specific binary packages built, but NOT to be promoted to main: <none>

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems: None

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have odd Built-Using entries
- not a go package, no extra constraints to consider in that regard

Problems: None

[Security]
RULE: - Determine if the package may have security implications or history.
RULE: Err on the side of caution.
RULE: - If the package is security sensitive, you should review as much as you
RULE: can and then assign to the ubuntu-security team. The bug will then be
RULE: added to the prioritized list of MIR security reviews.

OK:
- history of CVEs does not look concerning (none)
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- does have a test suite that runs at build time
  - test suite fails will fail the build upon error.
- does have a non-trivial test suite that runs as autopkgtest
  TBH It is rather simple but matching the library and run via
  autopkgtest-pkg-perl
- no special HW required
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is slow but ok (not much code)
- Debian/Ubuntu update history is slow but ok (not much code)
- the current release is packaged
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- d/rules is rather clean (as clean as possible)
- It is not on the lto-disabled list

Problems: None

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (perl)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- use of setuid, but ok because <TBD> (prefer systemd to set those
  for services)
- no important open bugs (crashers, etc) in Debian or Ubuntu (...

[Christian Ehrhardt  (paelzer)]

Reviewed, approved and showing up in component mismatches.

I set it to "Fix Committed" and subscribed ubuntu-archive admins to handle the promotion of the package to main.

[Steve Langasek (vorlon)]

Override component to main
libio-interactive-perl 1.023-1 in jammy: universe/perl -> main
libio-interactive-perl 1.023-1 in jammy amd64: universe/perl/optional/100% -> main
libio-interactive-perl 1.023-1 in jammy arm64: universe/perl/optional/100% -> main
libio-interactive-perl 1.023-1 in jammy armhf: universe/perl/optional/100% -> main
libio-interactive-perl 1.023-1 in jammy i386: universe/perl/optional/100% -> main
libio-interactive-perl 1.023-1 in jammy ppc64el: universe/perl/optional/100% -> main
libio-interactive-perl 1.023-1 in jammy riscv64: universe/perl/optional/100% -> main
libio-interactive-perl 1.023-1 in jammy s390x: universe/perl/optional/100% -> main
8 publications overridden.