horizon always assumes keystone admin endpoint is configured

[Vishal Manchanda]

Some horizon integration tests[1] start failing after devstack stops
creating default keystone admin endpoint[2].

(amotoki)
horizon always assume keystone admin endpoint is configured. Otherwise horizon does not work. keystone does not distinguish public and admin endpoints anymore after Train
and there is no functional difference from other endpoints.
There is no need that horizon requires 'admin' endpoint is configured.
It is better to use OPENSTACK_ENDPOINT_TYPE setting (which defaults to 'publicURL') for all operations.

[1] https://paste.openstack.org/show/810942/
[2] https://review.opendev.org/c/openstack/devstack/+/777345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/817558
Committed: https://opendev.org/openstack/horizon/commit/f9bab3fe195eb13635aa70cb910d94df98d66cf3
Submitter: "Zuul (22348)"
Branch: master

commit f9bab3fe195eb13635aa70cb910d94df98d66cf3
Author: manchandavishal <email address hidden>
Date: Thu Nov 11 18:50:53 2021 +0530

    Create Keystone admin endpoint for horizon integartion job

    CI job "horizon-integration-tests" needs an admin endpoint. Since
    [1] devstack does not create it by default. This patch enables it
    in this job now.

    [1] https://review.opendev.org/c/openstack/devstack/+/777345

    Related-Bug: #1950659
    Change-Id: I5a81344ea3aaa182d8b4d6a15a6240d3c99557cf

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/horizon/+/835172

[Akihiro Motoki (amotoki)]

Changing the priority to High.
horizon assumes 'admin' endpoint in previous releases, so it does not affect upgrades.
For new deployments, 'admin' endpoint may need to be configured explicitly (depending on deployment tools), so it is nice to fix it soon.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/yoga
Review: https://review.opendev.org/c/openstack/horizon/+/835143

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/835172
Committed: https://opendev.org/openstack/horizon/commit/35a490f4ec734156d8573d43d7ac3225379433c7
Submitter: "Zuul (22348)"
Branch: master

commit 35a490f4ec734156d8573d43d7ac3225379433c7
Author: Akihiro Motoki <email address hidden>
Date: Fri Mar 25 14:08:17 2022 +0900

    Do not assume keystone admin endpoint

    keystone does not distinguish public and admin endpoints since
    Train [1], so there is no need to use a separate endpoint for
    keystone admin operations. admin endpoint still can be configured
    but there is no functional difference anymore from other endpoints.
    We do not need to require admin endpoint and can use an endpoint
    specified by OPENSTACK_ENDPOINT_TYPE for all API operations.

    This commit reverts commit f9bab3fe195eb13635aa70cb910d94df98d66cf3
    as we no longer need the workaround.

    [1] https://review.opendev.org/c/openstack/keystone/+/664246

    Closes-Bug: #1950659
    Change-Id: I2660fd2df8081e1d2d9c84626037f94bd9d137a5

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/horizon/+/835143
Committed: https://opendev.org/openstack/horizon/commit/3a6569960247c578441ee34c1b054da8e77f6481
Submitter: "Zuul (22348)"
Branch: stable/yoga

commit 3a6569960247c578441ee34c1b054da8e77f6481
Author: Akihiro Motoki <email address hidden>
Date: Fri Mar 25 14:08:17 2022 +0900

    Do not assume keystone admin endpoint

    keystone does not distinguish public and admin endpoints since
    Train [1], so there is no need to use a separate endpoint for
    keystone admin operations. admin endpoint still can be configured
    but there is no functional difference anymore from other endpoints.
    We do not need to require admin endpoint and can use an endpoint
    specified by OPENSTACK_ENDPOINT_TYPE for all API operations.

    This commit reverts commit f9bab3fe195eb13635aa70cb910d94df98d66cf3
    as we no longer need the workaround.

    [1] https://review.opendev.org/c/openstack/keystone/+/664246

    Closes-Bug: #1950659
    Change-Id: I2660fd2df8081e1d2d9c84626037f94bd9d137a5

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 22.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/horizon 22.2.0 release.