overriding whole_disk_images is not working - cannot force use of overcloud-full image

[Marios Andreou]

As seen at [1] setting whole_disk_images: false does not work for forcing the use of overcloud-full. The variable is passed correctly ("whole_disk_images: false" in the zuul vars at [2]).

However the deployment is still fetching and using the overcloud-hardened-uefi image [3]

 2021-11-01 13:23:33.815174 | primary | will download https://images.rdoproject.org/centos9/master/rdo_trunk/tripleo-ci-testing/overcloud-hardened-uefi-full.qcow2 with md5sum of 4f992cd2cd9d6a068fcb9aa84d343bcd

I have confirmed that the problem is we are setting this to true in the config files [4]. With the test patch at [5] I was able to force the use of the overcloud-full image [6]

 2021-11-03 11:42:36.887788 | primary | will download https://images.rdoproject.org/centos9/master/rdo_trunk/tripleo-ci-testing/overcloud-full.tar with md5sum of faa94985409059f3b4db18d386db1d75

[1] https://review.rdoproject.org/r/c/testproject/+/36267/15/.zuul.yaml
[2] https://logserver.rdoproject.org/67/36267/15/check/tripleo-stream9-development-centos-9-ovb-3ctlr_1comp-featureset001-master/e73d2f2/zuul-info/inventory.yaml
[3] https://logserver.rdoproject.org/67/36267/15/check/tripleo-stream9-development-centos-9-ovb-3ctlr_1comp-featureset001-master/e73d2f2/job-output.txt
[4] https://opendev.org/openstack/tripleo-quickstart/src/commit/abe38cf58d2346f7818e9eca479cb193d7c0c89a/config/release/tripleo-ci/CentOS-8/master.yml#L31
[5] https://review.opendev.org/c/openstack/tripleo-quickstart/+/816313/3/config/release/tripleo-ci/CentOS-9/promotion-testing-hash-master.yml
[6] https://logserver.rdoproject.org/67/36267/22/check/tripleo-stream9-development-centos-9-ovb-3ctlr_1comp-featureset001-master/503c712/job-output.txt

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816640

[Marios Andreou (marios-b)]

patches posted for tripleo-quickstart/tripleo-quickstart-extras:

12:58 < opendevreview> Marios Andreou proposed openstack/tripleo-quickstart master: Remove explicit set for whole_disk_image: true https://review.opendev.org/c/openstack/tripleo-quickstart/+/816313

12:59 < opendevreview> Marios Andreou proposed openstack/tripleo-quickstart-extras master: Set whole_disk_images default to false https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816640

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Marios Andreou <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816640
Reason: dont need this one we keep https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816759/ https://review.opendev.org/c/openstack/tripleo-quickstart/+/816313

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/817243

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/817243
Committed: https://opendev.org/openstack/tripleo-quickstart-extras/commit/0610a8875ab6610e561df74a8c11cad6a12a4c7c
Submitter: "Zuul (22348)"
Branch: master

commit 0610a8875ab6610e561df74a8c11cad6a12a4c7c
Author: Marios Andreou <email address hidden>
Date: Tue Nov 9 17:42:19 2021 +0200

    Use whole_disk_images if this is passed through job vars

    Change-Id: I5d02ae06f0f8cd199754ef83300ee90a10c1a0bb
    Related-Bug: 1949765

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/816313
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/21593608ca91f5f326b57b9cc2fe562d67ab6219
Submitter: "Zuul (22348)"
Branch: master

commit 21593608ca91f5f326b57b9cc2fe562d67ab6219
Author: Marios Andreou <email address hidden>
Date: Tue Nov 2 11:41:52 2021 +0200

    Remove explicit set for whole_disk_image: true

    As described in the related-bug we should stop hard coding the value
    to true in the release files otherwise we cannot override it with zuul
    vars.

    Also, as the only role which consumes whole_disk_image, the libvirt
    role now depends on extras-common.

    Also explicitly pass the whole_disk_image var to the molecule test
    as the extras-common role is not in play for those. Patch at [1] lets
    us override with job vars or sets this according to branch.

    [1] https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/817243
    Related-Bug: 1949765
    Change-Id: I0b555676ce565d142a08e9d38d9e3c8ee7cb1a92

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/818766

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Ronelle Landy <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart/+/818766

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-quickstart/+/818766
Committed: https://opendev.org/openstack/tripleo-quickstart/commit/7d940a883e5fe3059b00574384f5c43244f9feaa
Submitter: "Zuul (22348)"
Branch: master

commit 7d940a883e5fe3059b00574384f5c43244f9feaa
Author: Juan Badia Payno <email address hidden>
Date: Mon Nov 22 14:14:47 2021 +0100

    overcloud-full is uefi but VMs are defined as BIOS

    Created a new parameter libvirt_boot_mode which is set depending on
    the release to bios or uefi.
    Depending on the libvirt_boot_mode the boot_mode is set on the
    instack.json file and the libvirt xml file is set accordingly
    to have whether uefi or bios boot vm.

    Change-Id: Ide055d0ed8cc86af31ee512f2e4a632447750bbe
    Related-Bug: 1949765