Issue submitting collections via Moodle

[Kristina Hoeppner]

Reported as issue with bug #1862370

This item causes a regression:

Moodle: Students unable to submit a Collection in a Mahara assignment

Argument 1 passed to Submissions\Repository\SubmissionRepository::findLatestReleasingSubmissionByGroupAndPortfolioElement() must be of the type int, null given, called in htdocs/module/submissions/lib.php on line 247

Patch at https://bugs.launchpad.net/mahara/+bug/1862370/+attachment/5536383/+files/Moodle%20Collection%20submission%20regression.patch

[Kristina Hoeppner (kris-hoeppner)]

Hi Tim,

Can you please provide more information? Which version of Moodle? The MNet Mahara assignment submission plugin or the web services one?

Thank you
Kristina

[Tim Lock (timlock)]

Hi Kristina,

Moodle Submission plugin version 2018053100.

[David Balch (davidbalch)]

I've encountered this with:

 * Mahara 21.04.1 (module submissions 2020102700)
 * Moodle 3.9.10
 * assignsubmission_maharaws 1.5.1 (2021081800)

It occurs in assignments with "Lock submitted portfolios" set to "No": When the student edits their submission, selects a portfolio, and saves changes, an unrecoverable error occurs (errorwsrequest).

Tim's patch fixes this submission failure for me (although it doesn't apply cleanly to this Mahara version).

[Robert Lyon (robertl-9)]

I believe the fix for this issue is actually a bit further up in the code path.

The fix here https://reviews.mahara.org/#/c/12034/ was released in 21.04.2_RELEASE to fix this exact problem

Cheers
Robert