OVB jobs failing on 'modify-image' task: "mount: /tmp/tmp.*: wrong fs type, bad option, bad superblock on /dev/nbd0"

[Douglas Viroel]

OVBs jobs are failing on 'modify-image' task with the following error:

| STDERR:
|
| + type tripleo-mount-image
| /bin/sh: line 1: type: tripleo-mount-image: not found
| + modprobe nbd
| + qemu-nbd --format raw --connect /dev/nbd0 /home/zuul/overcloud-full.qcow2
| + mount /dev/nbd0 /tmp/tmp.2AwKlud4pq
| mount: /tmp/tmp.2AwKlud4pq: wrong fs type, bad option, bad superblock on /dev/nbd0, missing codepage or helper program, or other error.

https://logserver.rdoproject.org/78/36478/2/check/periodic-tripleo-ci-centos-8-ovb-1ctlr_2comp-featureset020-victoria/d1d01ff/job-output.txt
https://logserver.rdoproject.org/89/36489/1/check/periodic-tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset035-victoria/f942fdb/job-output.txt
https://logserver.rdoproject.org/78/36478/2/check/periodic-tripleo-ci-centos-8-ovb-1ctlr_2comp-featureset020-train/5c66677/job-output.txt

Possible patch that introduce the issue:
https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/809487

[Ronelle Landy (rlandy)]

Secondary error:

chandan pointed this error earlier "/bin/tripleo-mount-image: line 210: [: missing `]'"

https://review.rdoproject.org/zuul/builds?job_name=tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001

[chandan kumar (chkumar246)]

https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/815880/1 and https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/815881 are the reverted patch.

[Ronelle Landy (rlandy)]

revert merged - closing this out

[Steve Baker (steve-stevebaker)]

I've proposed this change again with image format detection on the fallback path https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816103

[Ronelle Landy (rlandy)]

Fix https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/816103 merged today - closing this out

[Steve Baker (steve-stevebaker)]

This was fixed by https://review.opendev.org/c/openstack/tripleo-quickstart/+/813553