Allow effects without parameters in effects_refactoring branch

[Daniel Schürmann]

Currently an effects preset without knobs or buttons is treated as empty.
This prevents to use LV2 effects without parameters and leads to some inconsistent states in Mixxx.

The issue can be fixed around EffectPreset::isEmpty()

[Be (be.ing)]

LV2 effects without parameters? Do any of those exist? What would be a use case?

[Daniel Schürmann (daschuer)]

You can easily create an effect without a parameter. Even though this is a rare use case, it is not correct to consider an effect without a parameter as not existing.

[Be (be.ing)]

Once again, bikeshedding hypothetical concerns creates a hostile environment to contribute. Provide a reason why Mixxx should be made more complicated to handle this or don't talk about it please.

[ronso0 (ronso0)]

@daschuer
Can you share a pointer to the code you refer to, please? Just to get an idea of how "more complicated" the code would get.

Let's put this on the ToDo/'Check again' list to discuss after merge.

[Daniel Schürmann (daschuer)]

The function is implemented here:
https://github.com/mixxxdj/mixxx/blob/e817b69a940ad5d573e0e41d856298b8ff708f7a/src/effects/presets/effectpreset.h#L26

It is used for instance here:
https://github.com/mixxxdj/mixxx/blob/e817b69a940ad5d573e0e41d856298b8ff708f7a/src/effects/presets/effectchainpresetmanager.cpp#L124

[Daniel Schürmann (daschuer)]

New, to prevent this from expire.

[Be (be.ing)]

No real world use case has been presented to justify this.

[Daniel Schürmann (daschuer)]

See: https://bugs.launchpad.net/mixxx/+bug/1947798/comments/2

[Launchpad Janitor (janitor)]

[Expired for Mixxx because there has been no activity for 60 days.]

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/10565