vs_config: dependency cycles detected with hw-offload

Bug #1946985 reported by David Vallee Delisle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
puppet-vswitch
Fix Released
Undecided
Unassigned

Bug Description

As per [1], we need to remove the notify in the hw-offload key of the vs_config hash.

[1]
~~~
Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
   (file: /etc/puppet/hiera.yaml)
Warning: Undefined variable '::deploy_config_name';
   (file & line not available)
Warning: Unknown variable: '::deployment_type'. (file: /etc/puppet/modules/tripleo/manifests/packages.pp, line: 39, column: 69)
Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/7.10/deprecated_language.html
   (file & line not available)
Notice: Compiled catalog for computevdpa-0.home.arpa in environment production in 0.23 seconds
Error: Found 1 dependency cycle:
(Service[openvswitch] => Vs_config[other_config:hw-offload] => Service[openvswitch])\nTry the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz
Error: Failed to apply catalog: One or more resource dependency cycles detected in graph
Application:
   Initial environment: production
   Converged environment: production
         Run mode: user
Changes:
Events:
          Failure: 2
            Total: 2
Resources:
           Failed: 2
      Out of sync: 2
            Total: 2
Time:
   Config retrieval: 0.29
         Last run: 1634131884
            Total: 0.02
Version:
           Config: 1634131883
           Puppet: 7.10.0
~~~

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-vswitch (master)
Changed in puppet-vswitch:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on puppet-vswitch (master)

Change abandoned by "David Vallee Delisle <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/813824
Reason: https://review.opendev.org/c/openstack/puppet-vswitch/+/813964 is better

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-vswitch (master)

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/813964
Committed: https://opendev.org/openstack/puppet-vswitch/commit/1fe71cf5e359c8f83f11b2673620be822423bf47
Submitter: "Zuul (22348)"
Branch: master

commit 1fe71cf5e359c8f83f11b2673620be822423bf47
Author: Takashi Kajinami <email address hidden>
Date: Thu Oct 14 17:28:41 2021 +0900

    Do not use service resource to restart openvswitch service

    Closes-Bug: #1946985
    Change-Id: Idac29b0ea6794a52ae9146da8105ebbaf65ee9a3

Changed in puppet-vswitch:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-vswitch (stable/xena)

Fix proposed to branch: stable/xena
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/817105

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-vswitch (stable/xena)

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/817105
Committed: https://opendev.org/openstack/puppet-vswitch/commit/f5ee885fffca3d079a014fb19aa96b5579375a6b
Submitter: "Zuul (22348)"
Branch: stable/xena

commit f5ee885fffca3d079a014fb19aa96b5579375a6b
Author: Takashi Kajinami <email address hidden>
Date: Thu Oct 14 17:28:41 2021 +0900

    Do not use service resource to restart openvswitch service

    Closes-Bug: #1946985
    Change-Id: Idac29b0ea6794a52ae9146da8105ebbaf65ee9a3
    (cherry picked from commit 1fe71cf5e359c8f83f11b2673620be822423bf47)

tags: added: in-stable-xena
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-vswitch 16.0.0

This issue was fixed in the openstack/puppet-vswitch 16.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to puppet-vswitch (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-vswitch/+/849950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to puppet-vswitch (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/puppet-vswitch/+/849950
Committed: https://opendev.org/openstack/puppet-vswitch/commit/ee7c31bf5f3f8e5188df0ec2b201b31d47c8d923
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit ee7c31bf5f3f8e5188df0ec2b201b31d47c8d923
Author: Takashi Kajinami <email address hidden>
Date: Thu Oct 14 17:28:41 2021 +0900

    Do not use service resource to restart openvswitch service

    Conflicts:
            manifests/dpdk.pp

    Backport note:
    This was initially implemented to fix the regression caused by [1],
    however it turned out the same issue is triggered by the dependency
    implemented in puppet-ovn, so I'm backporting this to stable/wallaby
    as well.

    [1] 96dd49f1ae979d479ccb69b8e5f5dccd030cf7ff

    Closes-Bug: #1946985
    Change-Id: Idac29b0ea6794a52ae9146da8105ebbaf65ee9a3
    (cherry picked from commit 1fe71cf5e359c8f83f11b2673620be822423bf47)
    (cherry picked from commit f5ee885fffca3d079a014fb19aa96b5579375a6b)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-vswitch 14.4.2

This issue was fixed in the openstack/puppet-vswitch 14.4.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/puppet-vswitch 15.4.1

This issue was fixed in the openstack/puppet-vswitch 15.4.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.