[upstream] Attach dialog default layout leaves very little room for file list because of the image preview

[Alistair Cunningham]

The dialog to attach a file to an email is badly formatted when an image file with a long filename is selected. The image preview takes up almost all the dialog width, leaving very little space for the list of files. This is particularly a problem when the first file in a directory happens to be an image with a long filename.

ProblemType: Bug
DistroRelease: Ubuntu 21.10
Package: thunderbird 1:91.1.1+build2-0ubuntu1
ProcVersionSignature: Ubuntu 5.13.0-16.16-generic 5.13.13
Uname: Linux 5.13.0-16-generic x86_64
AddonCompatCheckDisabled: False
ApportVersion: 2.20.11-0ubuntu69
Architecture: amd64
AudioDevicesInUse:
 USER PID ACCESS COMMAND
 /dev/snd/controlC0: alistair 2076 F.... pulseaudio
BuildID: 20210916142849
CasperMD5CheckResult: unknown
Channel: Unavailable
CurrentDesktop: Unity:Unity7:ubuntu
Date: Fri Oct 1 08:48:38 2021
ForcedLayersAccel: False
IfupdownConfig:
 # interfaces(5) file used by ifup(8) and ifdown(8)
 # Include files from /etc/network/interfaces.d:
 source-directory /etc/network/interfaces.d
IncompatibleExtensions:
 Lightning - {e2fda1a4-762b-4020-b5ad-a41df1933103}
 English (GB) Language Pack - <email address hidden>
 Thunderbird (default) - {972ce4c6-7e08-4474-a285-3208198ce6fd}
InstallationDate: Installed on 2020-07-14 (443 days ago)
InstallationMedia: Ubuntu 20.04 LTS "Focal Fossa" - Release amd64 (20200423)
IpRoute:
 default via 172.30.3.254 dev wlp0s20f3 proto dhcp metric 600
 10.0.0.0/24 dev wg0 proto kernel scope link src 10.0.0.2
 169.254.0.0/16 dev wg0 scope link metric 1000
 172.30.0.0/22 dev wlp0s20f3 proto kernel scope link src 172.30.0.92 metric 600
PrefErrors: Unexpected character ',' before close parenthesis @ /usr/lib/thunderbird/omni.ja:greprefs.js:359
PrefSources: prefs.js
Profiles: Profile0 (Default) - LastVersion=91.1.1/20210916142849 (In use)
RebootRequiredPkgs: Error: path contained symlinks.
RunningIncompatibleAddons: True
SourcePackage: thunderbird
UpgradeStatus: Upgraded to impish on 2021-09-24 (6 days ago)
dmi.bios.date: 06/21/2021
dmi.bios.release: 1.19
dmi.bios.vendor: LENOVO
dmi.bios.version: N2WET29W (1.19 )
dmi.board.asset.tag: Not Available
dmi.board.name: 20U9CTO1WW
dmi.board.vendor: LENOVO
dmi.board.version: SDK0R32862 WIN
dmi.chassis.asset.tag: No Asset Information
dmi.chassis.type: 10
dmi.chassis.vendor: LENOVO
dmi.chassis.version: None
dmi.ec.firmware.release: 1.8
dmi.modalias: dmi:bvnLENOVO:bvrN2WET29W(1.19):bd06/21/2021:br1.19:efr1.8:svnLENOVO:pn20U9CTO1WW:pvrThinkPadX1CarbonGen8:skuLENOVO_MT_20U9_BU_Think_FM_ThinkPadX1CarbonGen8:rvnLENOVO:rn20U9CTO1WW:rvrSDK0R32862WIN:cvnLENOVO:ct10:cvrNone:
dmi.product.family: ThinkPad X1 Carbon Gen 8
dmi.product.name: 20U9CTO1WW
dmi.product.sku: LENOVO_MT_20U9_BU_Think_FM_ThinkPad X1 Carbon Gen 8
dmi.product.version: ThinkPad X1 Carbon Gen 8
dmi.sys.vendor: LENOVO

[Olivier Tilloy (osomon)]

I think I can see what you mean. It's not really bad formatting, it's the layout of the dialog itself that leaves very little room for the file list, with the preview on the right and the shortcuts on the left. The dialog can be manually resized to mitigate the problem, but the default layout isn't very user-friendly.

Could you please file an upstream bug for this at https://bugzilla.mozilla.org/enter_bug.cgi#h=dupes|Thunderbird and share the link to it here? Thanks!

[Bugzilla-7 (bugzilla-7)]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:93.0) Gecko/20100101 Firefox/93.0

Steps to reproduce:

The dialog to attach a file to an email is badly formatted when an image file with a long filename is selected. The image preview takes up almost all the dialog width, leaving very little space for the list of files. This is particularly a problem when the first file in a directory happens to be an image with a long filename.

Expected results:

The list of files should be wide enough to be useful, obscuring part of the selected file name if necessary.

[Alistair Cunningham (acunningham)]

Certainly; this is done.

https://bugzilla.mozilla.org/show_bug.cgi?id=1734467

[Olivier Tilloy (osomon)]

Thanks Alistair!

[Mkmelin+mozilla (mkmelin+mozilla)]

Can you provide a screenshot? Sounds like you're referring to the normal OS dialog where one selects a file (nothing we can affect there).

[Bugzilla-7 (bugzilla-7)]

I just went to take the screenshot, and the problem has disappeared. The formatting now looks good. The dialog is the normal Gnome file selector. I did an "apt full-upgrade" earlier today, and notice that some Gnome packages such as gnome-menus were updated. Maybe this has fixed the problem?

[Mkmelin+mozilla (mkmelin+mozilla)]

Ok, glad it worked out.

[Alistair Cunningham (acunningham)]

This problem appears to be fixed after updating to the latest Gnome packages in Ubuntu 21.10. I think this bug report can be closed.

[Olivier Tilloy (osomon)]

Mmm, that's weird, I can see the change that you're mentioning, but I went to look at the apt history log and I don't see any update that would have obviously affected this dialog.

Anyway, since the bug is fixed, let's just close it. Feel free to re-open if it surfaces again.

[Alistair Cunningham (acunningham)]

Thank you!