use downstream pop!_os patch for global theme switching

[Muqtadir]

Pop!_OS manages to switch the Gnome-shell and GTK theme since 20.04 without the use of user-theme gnome-shell-extension by patching Gnome-shell.

The following files should be patched:

- https://git.launchpad.net/ubuntu/+source/gnome-shell/tree/js/ui/main.js?h=applied/ubuntu/impish

- https://git.launchpad.net/ubuntu/+source/gnome-shell/tree/debian/ubuntu-session-mods/ubuntu.json?h=applied/ubuntu/impish

Yaru-theme gnome-shell gresource should use this PR if patched:
- https://github.com/ubuntu/yaru/pull/2945

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "pop-dark-theme.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Daniel van Vugt (vanvugt)]

Thanks for the enhancement request. It appears you're recommending changing multiple files but the patch in comment #1 only changes one file. Can you clarify the full set of patches required?

[Muqtadir (muqtxdir-m)]

Hi Daniel van Vugt,

Sorry for not sharing the complete-patch file, I generated the above patch on top of gnome-shell-40.2 package. please have a look at it.

Note: For this to work Yaru needs to be modified/patched (i.e. PR: https://github.com/ubuntu/yaru/pull/2945). will merge this PR into master once this patch lands on ubuntu

[Muqtadir (muqtxdir-m)]

Hi @vanvugt, could this be expected to land in ubuntu-21.10 ?

[Daniel van Vugt (vanvugt)]

I don't have the power to make it happen but would recommend as a first step you should create a formal merge request to the ubuntu/master branch here:

https://salsa.debian.org/gnome-team/gnome-shell/-/tree/ubuntu/master

[Sebastien Bacher (seb128)]

The description of the change and why it's needed is not really clear there, you are going to need to provide more details if you want to see the changes considered, also please use a merge request as pointed out by Daniel

[Muqtadir (muqtxdir-m)]

Hi @seb128 and @vanvugt,

> I don't have the power to make it happen but would recommend as a first step you should create a formal merge request to the ubuntu/master branch here:
https://salsa.debian.org/gnome-team/gnome-shell/-/tree/ubuntu/master

I've asked the Pop!_OS maintainers of gnome-shell to upstream their patch on their github issue-tracker and one of the maintainer replied that he will do so (see: https://github.com/pop-os/gnome-shell/issues/77).

>The description of the change and why it's needed is not really clear there, you are going to need to provide more details if you want to see the changes considered, also please use a merge request as pointed out by Daniel

Sorry for being vague about the reasoning and description of the issue

[Reason]
The Appearance-panel in gnome-control-center only switches GTK themes but not GNOME-Shell theme. The possibility of also switching the GNOME-Shell was mentioned in the sprint session of Yaru development during ubuntu 20.04 release cycle. (quoting from the blogpost New Ubuntu Theme in Development for 20.04: "In future, we would also like these settings to switch the theme for shell elements, such as the top bar and notification bubbles. Achieving this without requiring a logout each time will require additional work in GNOME Shell – something we are investigating" see: https://ubuntu.com/blog/new-ubuntu-theme-in-development-for-20-04)

[Impact]
Currently Yaru(light theme) is default for GTK and Yaru-dark(dark theme) is default for GNOME-Shell theme.This change would make Yaru(light theme) the default for both GTK and GNOME-Shell and give the desktop users the ability to Fully switch between both Light and Dark themes from Appearance panel out of the box without the need of using user-themes-gnome-shell-extension.

[Relevant Github discussion:]
see this discussion on Yaru's github discussions for more details: https://github.com/ubuntu/yaru/discussions/2677

[Relevant Yaru PR:]
see PR:https://github.com/ubuntu/yaru/pull/2945

[Muqtadir (muqtxdir-m)]

Hi just an update to the patch situation, Jeremy Soller of Pop!_OS was not able to get his salsa.debian.org account approved so instead I'll be proposing merge-request. Also removed the impish tag

[Jeremy Bícha (jbicha)]

Isn't this his Salsa account?

https://salsa.debian.org/jackpot51

[Muqtadir (muqtxdir-m)]

I think so yes, the user-name is identical to his Github user-name

[Muqtadir (muqtxdir-m)]

I created the MR here: https://salsa.debian.org/gnome-team/gnome-shell/-/merge_requests/56
Please have a look at it

[Muqtadir (muqtxdir-m)]

hi,

could you please close this issue-bug as it was merged to ubuntu-master branch: https://salsa.debian.org/gnome-team/gnome-shell/-/blob/ubuntu/master/debian/patches/ubuntu/main-Support-loading-multiple-Yaru-theme-variants.patch by Marco.

Thank you for everyone involved with this!

[Daniel van Vugt (vanvugt)]

Yes commit 3f3080056b2 is in version 42~beta-1ubuntu1