system-info.version in YAML output needs ' ' quoting

Bug #1943623 reported by Colin Ian King
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
stress-ng (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Colin Ian King
Hirsute
Fix Released
Undecided
Colin Ian King
Impish
Fix Released
Undecided
Unassigned

Bug Description

== SRU Justification HIRSUTE/FOCAL ==

[Impact]

The system information YAML output from stress-ng is not quoting the system-info.version data. If this contains # then it really confuses YAML parsers.

[The Fix]

Upstream fix:

commit a52f236917f51a4fdc54873cc6ca33e24df1a41f
Author: Fabien Malfoy <email address hidden>
Date: Tue Sep 14 12:16:09 2021 +0200

    core-helper: Quote the system-info.version value in YAML metrics

[Test Plan]

Run:

stress-ng -Y output.yaml --cpu 1 -t 1

Examine the output.yaml file for the system-info version: field. Without the fix it is not in quotes. With the fix it is in ' ' quotes, e.g.:

      version: '#12 SMP Thu Jul 22 08:02:41 UTC 2021'

[Where problems could occur]

This changes just the yaml output and makes it now parsable. Problems may occur if folk have put in a workaround to parse the original buggy output.

The change does not affect core stress-ng functionality, so regression potential of breaking stress-ng is very small.

Revision history for this message
Colin Ian King (colin-king) wrote :

Fixed in stress-ng V0.13.02 (impish)

no longer affects: stress-ng
Changed in stress-ng (Ubuntu Impish):
status: New → Fix Committed
Changed in stress-ng (Ubuntu Hirsute):
status: New → In Progress
Changed in stress-ng (Ubuntu Focal):
status: New → In Progress
assignee: nobody → Colin Ian King (colin-king)
Changed in stress-ng (Ubuntu Hirsute):
assignee: nobody → Colin Ian King (colin-king)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Colin, or anyone else affected,

Accepted stress-ng into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/stress-ng/0.11.07-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in stress-ng (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Colin, or anyone else affected,

Accepted stress-ng into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/stress-ng/0.12.06-1ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in stress-ng (Ubuntu Hirsute):
status: In Progress → Fix Committed
tags: added: verification-needed-hirsute
Revision history for this message
Colin Ian King (colin-king) wrote :

Tested Hirsute, version field now has ' ' quotes:

--
system-info:
      stress-ng-version: 0.12.06
      run-by: cking
      date-yyyy-mm-dd: 2021:09:15
      time-hh-mm-ss: 08:50:04
      epoch-secs: 1631695804
      hostname: hirsute-amd64-efi
      sysname: Linux
      nodename: hirsute-amd64-efi
      release: 5.11.0-34-generic
      version: '#36-Ubuntu SMP Thu Aug 26 19:22:09 UTC 2021'
      machine: x86_64
      uptime: 660
      totalram: 4112830464
      freeram: 2290266112
      sharedram: 3575808
      bufferram: 84979712
      totalswap: 4112510976
      freeswap: 4112510976
      pagesize: 4096
      cpus: 2
      cpus-online: 2

Revision history for this message
Colin Ian King (colin-king) wrote :

Tested Focal, version field now has ' ' quotes:

---
system-info:
      stress-ng-version: 0.11.07
      run-by: cking
      date-yyyy-mm-dd: 2021:09:15
      time-hh-mm-ss: 08:58:13
      epoch-secs: 1631696293
      hostname: focal-amd64-efi
      sysname: Linux
      nodename: focal-amd64-efi
      release: 5.4.0-52-generic
      version: '#57-Ubuntu SMP Thu Oct 15 10:57:00 UTC 2020'
      machine: x86_64
      uptime: 1262
      totalram: 4122370048
      freeram: 1052516352
      sharedram: 3440640
      bufferram: 37695488
      totalswap: 4121948160
      freeswap: 4121948160
      pagesize: 4096
      cpus: 2
      cpus-online: 2
      ticks-per-second: 100

tags: added: verification-done verification-done-focal verification-done-hirsute
removed: verification-needed verification-needed-focal verification-needed-hirsute
Changed in stress-ng (Ubuntu Impish):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package stress-ng - 0.12.06-1ubuntu1

---------------
stress-ng (0.12.06-1ubuntu1) hirsute; urgency=medium

  * Quote the system-info.version value in YAML metrics (LP: #1943623)
   - upstream commit a52f236917f5 ("core-helper: Quote the
     system-info.version value in YAML metrics")

 -- Colin King <email address hidden> Tue, 14 Sep 2021 18:08:14 +0100

Changed in stress-ng (Ubuntu Hirsute):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for stress-ng has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package stress-ng - 0.11.07-1ubuntu1

---------------
stress-ng (0.11.07-1ubuntu1) focal; urgency=medium

  * Quote the system-info.version value in YAML metrics (LP: #1943623)
   - upstream commit a52f236917f5 ("core-helper: Quote the
     system-info.version value in YAML metrics")

 -- Colin King <email address hidden> Tue, 14 Sep 2021 18:08:14 +0100

Changed in stress-ng (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.