/etc/profile.d/juju-introspection.sh is not POSIX shell compatible

[Loïc Gomez]

On a model deployed with Juju 2.9.11, installing spamassassin yields a Syntax error as spamassassin post-installation script attempts to run sa-update as debian-spamd user, having /bin/sh as shell.

$ sudo dpkg --configure spamassassin
Setting up spamassassin (3.4.2-0ubuntu0.18.04.5) ...
-su: 92: /etc/profile.d/juju-introspection.sh: Syntax error: "(" unexpected (expecting "}")
dpkg: error processing package spamassassin (--configure):
 installed spamassassin package post-installation script subprocess returned error exit status 2
Errors were encountered while processing:
 spamassassin

/var/lib/dpkg/info/spamassassin.postinst:
> su - $OWNER -c "sa-update \
> --gpghomedir /var/lib/spamassassin/sa-update-keys \
> --import /usr/share/spamassassin/GPG.KEY"

$ sudo sh -c "su - $OWNER -c 'sa-update --gpghomedir /var/lib/spamassassin/sa-update-keys --import /usr/share/spamassassin/GPG.KEY'"
-su: 92: /etc/profile.d/juju-introspection.sh: Syntax error: "(" unexpected (expecting "}")

$ getent passwd debian-spamd
debian-spamd:x:113:119::/var/lib/spamassassin:/bin/sh

$ sudo sh
# . /etc/profile.d/juju-introspection.sh
sh: 92: /etc/profile.d/juju-introspection.sh: Syntax error: "(" unexpected (expecting "}")

Afaik, arrays are not part of POSIX shell specifications.
This bug probably affect other packages than spamassassin.

It seems to be an iteration of https://bugs.launchpad.net/juju/+bug/1770437

Thanks

[Loïc Gomez (kotodama)]

This commit introduced the functions affecting spamassassin post-install:
https://github.com/juju/juju/commit/8f848216473d8ac2af9d869386c0e8c24e87aac4#diff-9ea3cead53dc6fcc7b570811f43366947a2c6c68285042b7a2bd459caf500291

[Loïc Gomez (kotodama)]

Fixing PR: https://github.com/juju/juju/pull/13299

[Loïc Gomez (kotodama)]

Opened PR https://github.com/juju/juju/pull/13309 for 2.9 branch.

[Loïc Gomez (kotodama)]

Fix has been merged per https://github.com/juju/juju/pull/13309 and https://github.com/juju/juju/pull/13299