basic auth middleware can't be loaded by the python egg

[Takashi Kajinami]

The basic auth middleware was recently added[1] to implement simple auth mechanism, but this middleware is not listed in paste.filter_factory entrypoints. While we can use this middleware by defining its direct path,
we can't use the python egg as we can do for the other middleware.

[1] https://review.opendev.org/c/openstack/oslo.middleware/+/802234

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/oslo.middleware/+/805479

[Rabi Mishra (rabi)]

I don't think entrypoint is necessary, unless you want something like [1].

We use following in api-paste.ini and it would work.

[filter:basic_auth]
paste.filter_factory = oslo_middleware:oslo_middleware.basic_auth:BasicAuthMiddleware.factory.factory

[1] https://bugs.launchpad.net/oslo.middleware/+bug/1500509

[Takashi Kajinami (kajinamit)]

Thanks, Rabi.

You are totally correct and I wrongly explained the current situation.

I think this bug is still valid though, because we have entry points for the other middleware defined. However as you pointed this is not quite mandatory now.

I have updated the bug description and the commit message of my fix proposed. Please let me know if you find anything wrong...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/oslo.middleware/+/805479
Committed: https://opendev.org/openstack/oslo.middleware/commit/8e47bfc77c37610e0da577f13d7a3eb7894139a0
Submitter: "Zuul (22348)"
Branch: master

commit 8e47bfc77c37610e0da577f13d7a3eb7894139a0
Author: Takashi Kajinami <email address hidden>
Date: Sat Aug 21 20:19:48 2021 +0900

    Add paste.filter_factory entrypoint for basic auth middleware

    ... so that the middleware can be loaded using the python egg instead
    of the direct path.

    Closes-Bug: #1940738
    Change-Id: I57408766c120d2c9784f3886457e91ee7d30de1b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/oslo.middleware 4.5.0 release.