Packages omit variable for dependency declaration, breaks build-avoidance

[Michel Thebeau [WIND]]

Brief Description
-----------------
It was observed that the flock build outputs an older version of portieris application, and that the cause is an omitted dependency declaration. A quick survey of flock and monolithic build output suggest these two packages present the symptom:

stx-cert-manager-helm
stx-portieris-helm

Severity
--------
Major: System/Feature is usable but degraded - Flock build omits bug fixes for certain packages.

Steps to Reproduce
------------------
Examine flock build artifact stx-portieris-helm version and content to see missing bug fixes.

Expected Behavior
------------------
Bug fixes are included in build.

Actual Behavior
----------------
Bug fixes are omitted in build-avoidance builds

Reproducibility
---------------
May not be 100% reproducible. Flock build was seen to do this at 20210813T021017Z. But monolithic does not seem to have the symptom.

System Configuration
--------------------
Build-avoidance, flock builds, http://mirror.starlingx.cengn.ca/mirror/starlingx/master/centos/flock/

Branch/Pull Time/Commit
-----------------------
20210813T021017Z for example

Last Pass
---------
Probably day one of build-avoidance for the packages listed.

Timestamp/Logs
--------------
N/A

Test Activity
-------------
N/A

Workaround
----------
omit build avoidance.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/cert-manager-armada-app/+/804908

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/portieris-armada-app/+/804909

[Michel Thebeau [WIND] (mthebeau)]

Removing kickstart from the bug report describtion after verifying no discrepancy in the built RPMs.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/cert-manager-armada-app/+/804908
Committed: https://opendev.org/starlingx/cert-manager-armada-app/commit/f67ad524558c05b5cd17b77df4f3c362cf68aaf2
Submitter: "Zuul (22348)"
Branch: master

commit f67ad524558c05b5cd17b77df4f3c362cf68aaf2
Author: Michel Thebeau <email address hidden>
Date: Tue Aug 17 12:19:07 2021 -0400

    Add package dependancy for build-avoidance

    stx-cert-manager-helm contains both cert-manager-helm and
    python-k8sapp-cert-manager. Declare the relationship so that the
    build-avoidance will pick the right package versions When any of these
    is updated.

    Partial-Bug: 1940309

    Change-Id: I2cce6146df563bbe3b6911431a626a1111ebddd8
    Signed-off-by: Michel Thebeau <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/starlingx/portieris-armada-app/+/804909
Committed: https://opendev.org/starlingx/portieris-armada-app/commit/c790b755e9e1511d6b6a3dea9dbddf92d9d585d3
Submitter: "Zuul (22348)"
Branch: master

commit c790b755e9e1511d6b6a3dea9dbddf92d9d585d3
Author: Michel Thebeau <email address hidden>
Date: Tue Aug 17 12:05:55 2021 -0400

    Add package dependancy for build-avoidance

    stx-portieris-helm contains both portieris-helm and
    python-k8sapp-portieris. Declare the relationship so that the
    build-avoidance will pick the right package versions When any of these
    is updated.

    Partial-Bug: 1940309

    Change-Id: I07b10b4eb67bf043ece8acaf16afee2243407508
    Signed-off-by: Michel Thebeau <email address hidden>