New GStreamer equalizer range: -24..+12 instead of -1..+1

Bug #193929 reported by Johannes Sasongko
16
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
High
Adam Olsen

Bug Description

The GStreamer equalizer element changed the gain properties from -1..+1
(no specified unit) to -24..+12 dB. As the equalizer is now in
gst-plugins-good, it's not likely to change anymore.

I have no idea how the conversion works, but the old source seems to
indicate that the -1..+1 was equivalent to -12..+6 dB. If anyone knows
how to convert from the old to new values, please enlighten me.

The gst changeset:
http://webcvs.freedesktop.org/gstreamer/gst-plugins-good/gst/equalizer/gstiirequalizer.c?r1=1.19&r2=1.20

  affects exaile
  status confirmed
  milestone 0.2.12
  importance high
  subscribe

Revision history for this message
Adam Olsen (arolsen) wrote :

I've just emailed the gstreamer mailing list regarding this. I see a few problems, though. In our current equalizer.ini file, there are values such as -5.5511e-17, which shouldn't work. Only in the negative range, though. However, in the glade file, all the slider max an min values are 1 and -1.

I found the winamp equalizer presets file, and I can't really tell if it's also using a -24,12 range.

The biggest problem I see is detecting what version of gstreamer is being used and adjusting accordingly. Is the answer to use two different equalizer dialogs, and two different eqlualizer.ini files (for default values)? Such as Equalizer and Equalizer2? All the widget names could be the same, they would just have different ranges on the sliders.

Revision history for this message
Johannes Sasongko (sjohannes) wrote : [Bug 193929] Re: New GStreamer equalizer range: -24..+12 instead of -1..+1

> The biggest problem I see is detecting what version of gstreamer is
> being used and adjusting accordingly. Is the answer to use two
> different equalizer dialogs, and two different eqlualizer.ini files (for
> default values)? Such as Equalizer and Equalizer2? All the widget
> names could be the same, they would just have different ranges on the
> sliders.

To be honest I don't know. If it was up to me I'd be lazy and simply
change the dialog and defaults to the new range, destroying users'
custom presets on the way, also breaking support for earlier versions of
the eq plugin. Not very nice but yeah... that would save us from some
code pollution.

Adam Olsen (arolsen)
Changed in exaile:
status: Confirmed → Fix Committed
Revision history for this message
plun (plun) wrote :

The Equalizer works again... Thanks ! :)

A little difficult to adjust, just small adjustments otherwise distorted sound.

PS Equalizer is wrong spelled within Menu and Windows List :)

Revision history for this message
Adam Olsen (arolsen) wrote :

Where is the spelling mistake? I can't see it.

Revision history for this message
plun (plun) wrote :

Here (hopefully Nofrag is alive)

http://pix.nofrag.com/e/5/2/5f8c876772db08a262680227d4acd.html

- Menu tools

- Windows list (when active)

Thanks !

Revision history for this message
Adam Olsen (arolsen) wrote : Re: [Bug 193929] Re: New GStreamer equalizer range: -24..+12 instead of -1..+1

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Wow, that's really weird. What locale are you using?
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: http://getfiregpg.org

iD8DBQFH/NKMTSjho5GlGw8RAni0AKClpI1lhKd1LUuX1vagQ4GBcgi5EwCeMy5B
WlpA8TbkZlLlbBKrQHLdh3Q=
=jPG9
-----END PGP SIGNATURE-----

Revision history for this message
plun (plun) wrote :

Sorry, I missed your question.

I have 2 locales installed, swedish and english.
English is set to default. Running Hardy, up-to-date

I also tried a clean trunk install with the same spelling... :)

This is not a big deal if I am alone with this error... ;)

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

All "equalizer" texts are localised as "equaliser" in the en_GB locale (which is correct AFAIK); I'm quite sure that's what you're seeing in this case.

Changed in exaile:
assignee: nobody → arolsen
status: Fix Committed → Fix Released
Revision history for this message
Johannes Sasongko (sjohannes) wrote :

Er, I meant, almost all of them are localised that way. I think the translator missed the "Enable Equalizer" text.

Revision history for this message
Stefan Soriga (sgstefan) wrote :

I see "fix released", but I still have this problem, although i run with hardy-proposed. Can somebody be more explicit? Thanks.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.