tripleo cephadm deploy has require_min_compat_client luminous

Bug #1938833 reported by John Fulton
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
John Fulton

Bug Description

After using cephadm to deploy ceph with tripleo using the main branch the default client version is lumionus.

[ceph: root@oc0-controller-0 /]# ceph osd dump | grep require_min_compat_client
require_min_compat_client luminous
[ceph: root@oc0-controller-0 /]#

However, we specifically had the following patch to set this to mimic:

 https://review.opendev.org/c/openstack/tripleo-heat-templates/+/773539

in order to have: "simplified image clone semantics where non-protected snapshots can be cloned; and snapshots with linked clones can be removed and the space automatically reclaimed once all remaining linked clones are detached. This feature is enabled by default if the OSD “require-min-compat-client” flag is set to mimic or later; or can be overridden via the “rbd_default_clone_format” configuration option."

I believe this is a regression because we removed the ceph-ansible THT to set this but didn't add it to the cephadm THT. This bug should be used to track adding a similar task back for the cephadm case.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (master)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/803496
Committed: https://opendev.org/openstack/tripleo-ansible/commit/bb5e1cfaab7f579037af9517d4be37e1beea5094
Submitter: "Zuul (22348)"
Branch: master

commit bb5e1cfaab7f579037af9517d4be37e1beea5094
Author: John Fulton <email address hidden>
Date: Wed Aug 4 15:31:20 2021 +0000

    Enforce minimum Ceph client version to Mimic

    This is so that we can take advantage of the deferred deletion
    feature in Cinder. This change is done in Ansible instead of
    TripleO Heat Templates so that it is deployed_ceph compatible
    while still having an effect when deployed_ceph is not used.

    Closes-Bug: #1938833
    Change-Id: Ic76953f1a671ea0416da829acb37bd1d787a55dc

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/803683

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/803683
Committed: https://opendev.org/openstack/tripleo-ansible/commit/1d397c9bbc22c901332723240d0cf634ce04bc92
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 1d397c9bbc22c901332723240d0cf634ce04bc92
Author: John Fulton <email address hidden>
Date: Wed Aug 4 15:31:20 2021 +0000

    Enforce minimum Ceph client version to Mimic

    This is so that we can take advantage of the deferred deletion
    feature in Cinder. This change is done in Ansible instead of
    TripleO Heat Templates so that it is deployed_ceph compatible
    while still having an effect when deployed_ceph is not used.

    Closes-Bug: #1938833
    Change-Id: Ic76953f1a671ea0416da829acb37bd1d787a55dc
    (cherry picked from commit bb5e1cfaab7f579037af9517d4be37e1beea5094)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 3.3.0

This issue was fixed in the openstack/tripleo-ansible 3.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 4.1.0

This issue was fixed in the openstack/tripleo-ansible 4.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.