Angular should cache workstation/user setting values

Bug #1938729 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.6
Fix Released
Undecided
Unassigned

Bug Description

Evergreen 3.7

This is a continuation of bug #1848550.

The Angular client makes much heavier use of the "cascade" settings API for fetching workstation and user setting values. Additionally, since the API also returns org unit setting values, it is often used in lieu of the traditional org unit setting retrieval methods (e.g. this.org.settings(...)). To reduce the API calls for these lookups, their values should be cached in IndexedDB, similar to how direct org unit setting lookup values are cached.

Branch en route.

Revision history for this message
Bill Erickson (berick) wrote :
Changed in evergreen:
milestone: none → 3.7.2
assignee: Bill Erickson (berick) → nobody
tags: added: pullrequest
Revision history for this message
Bill Erickson (berick) wrote :

As with the other cache bugs, testing comes down to fetching some workstation settings (on Angular pages -- e.g. grid settings) and verifying they are not re-fetched on page reload.

Revision history for this message
Jason Boyer (jboyer) wrote :

Hi Bill, this looks good to me, signoff is here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jboyer/lp1938729_settings_cache_signoff / working/user/jboyer/lp1938729_settings_cache_signoff

Jason Boyer (jboyer)
tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Jason! This should help with some of the too-many-api-calls issues. Merged to 3.6 and up.

Changed in evergreen:
status: New → Fix Committed
assignee: Bill Erickson (berick) → nobody
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.