StackAction can't be used with ephemeral heat

[Rabi Mishra]

With ephemeral heat we create a new stack every time and StackAction is always 'CREATE'. There is a bunch of deployment logic that exists today based on StackAction. Though the deployment actions are 'normally' expected to be idempotent, I've seen cases where re-run of some of those create issues.

We should fix those as the behavior would be different from before.

- Node network configuration based on StackAction[1]
- Restarting HA services during stack update[2]
- Run octavia_controller_check with stack update[3]

There may be more that I've missed.

[1] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/roles/tripleo_network_config/tasks/main.yml#L120

[2] https://github.com/openstack/tripleo-heat-templates/blob/master/container_config_scripts/pacemaker_restart_bundle.sh#L29

[3] https://github.com/openstack/tripleo-ansible/blob/master/tripleo_ansible/playbooks/octavia-files.yaml#L43

[Bogdan Dobrelya (bogdando)]

...or we could follow the path of the virtual stack update mark used for undercloud deployment via ephemeral heat

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/801299
Committed: https://opendev.org/openstack/tripleo-ansible/commit/b26666e9f942eb2e63e06abb0fcb426b4b332e69
Submitter: "Zuul (22348)"
Branch: master

commit b26666e9f942eb2e63e06abb0fcb426b4b332e69
Author: Brendan Shephard <email address hidden>
Date: Mon Jul 19 22:41:59 2021 +1000

    Remove stack_action from Octavia deployment

    Due to ephemeral Heat, the stack_action will now
    always be CREATE. This breaks certain jobs relying on
    the UPDATE action. In the case of Octavia, relying
    on generate_certs alone should be enough.

    Partial-Bug: #1936138
    Change-Id: Id12c0971fd1c52d92a0983917fe12d42f27364f8

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/801301
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/5771d93182862592fa69d20662b9fcaa339bbf5a
Submitter: "Zuul (22348)"
Branch: master

commit 5771d93182862592fa69d20662b9fcaa339bbf5a
Author: Brendan Shephard <email address hidden>
Date: Mon Jul 19 23:05:20 2021 +1000

    Remove StackAction from Octavia deployment

    Since ephemeral Heat, StackAction is now always
    CREATE. Subsequentaly, it no longer serves the
    intended purpose for the Octavia deployment.

    This change removes StackAction from the template.

    Partial-Bug: #1936138
    Depends-on: https://review.opendev.org/c/openstack/tripleo-ansible/+/801299
    Change-Id: Ia3f4de0028a4c264a9f2d1277878221969e180d5

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/847817

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847878

[OpenStack Infra (hudson-openstack)]

Change abandoned by "chandan kumar <email address hidden>" on branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/847817
Reason: in order to clear the gate and get https://review.opendev.org/c/openstack/tripleo-ansible/+/848075/ to fix sc01, 04, 10 , we are abandoning it and will restore the patch later.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/847817
Committed: https://opendev.org/openstack/tripleo-ansible/commit/9bdc0bbf1e9d38f331f2f0d8248896c34f85f7c5
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 9bdc0bbf1e9d38f331f2f0d8248896c34f85f7c5
Author: Brendan Shephard <email address hidden>
Date: Mon Jul 19 22:41:59 2021 +1000

    Remove stack_action from Octavia deployment

    Due to ephemeral Heat, the stack_action will now
    always be CREATE. This breaks certain jobs relying on
    the UPDATE action. In the case of Octavia, relying
    on generate_certs alone should be enough.

    Partial-Bug: #1936138
    Change-Id: Id12c0971fd1c52d92a0983917fe12d42f27364f8
    (cherry picked from commit b26666e9f942eb2e63e06abb0fcb426b4b332e69)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/847878
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/72d679af415eb7e77e1de423c5b1262a883ec215
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 72d679af415eb7e77e1de423c5b1262a883ec215
Author: Brendan Shephard <email address hidden>
Date: Mon Jul 19 23:05:20 2021 +1000

    Remove StackAction from Octavia deployment

    Since ephemeral Heat, StackAction is now always
    CREATE. Subsequentaly, it no longer serves the
    intended purpose for the Octavia deployment.

    This change removes StackAction from the template.

    Partial-Bug: #1936138
    Depends-on: https://review.opendev.org/c/openstack/tripleo-ansible/+/847817
    Change-Id: Ia3f4de0028a4c264a9f2d1277878221969e180d5
    (cherry picked from commit 5771d93182862592fa69d20662b9fcaa339bbf5a)