Fix file_descriptors total_limit in rabbitmq_limits role

Bug #1934656 reported by chris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
chris

Bug Description

Description
===========
Ansible role `rabbitmq_limits` Task `Get file_descriptors total_limit` has incorrect command line argument.

~~~
"{{ container_cli }}"
    exec $("{{ container_cli }}" ps -q --filter "name=rabbitmq" | head -1)
    rabbitmqctl eval 'sysctl -n fs.file-max'
~~~

Running `openstack tripleo validator run --validation rabbitmq-limits` fails with the below

"stderr": "Error (argument validation): \"syntax error before: fs\"\nArguments given:\n\teval sysctl -n fs.file-max\n\n\u001b[1mUsage\u001b[0m\n\nrabbitmqctl [--node <node>] [--longnames] [--quiet] eval <expression>\nError: non zero exit code: 64: OCI runtime error",

Running that command which fails in the ansible task
~~~
podman exec $(podman ps -q --filter \"name=rabbitmq\" | head -1) rabbitmqctl eval 'sysctl -n fs.file-max'
Error (argument validation): "syntax error before: fs"
Arguments given:
        eval sysctl -n fs.file-max

Usage

rabbitmqctl [--node <node>] [--longnames] [--quiet] eval <expression>
Error: non zero exit code: 64: OCI runtime error
~~~

chris (chrisbro)
Changed in tripleo:
assignee: nobody → chris (chrisbro)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (master)
Changed in tripleo:
status: New → In Progress
Revision history for this message
Brendan Shephard (bshephar) wrote :

Verifying the proposed solution works

[root@overcloud-controller-0 ~]# podman exec -it $(podman ps --filter name=rabbitmq-bundle -q) sysctl -n fs.file-max

4788829

Changed in tripleo:
milestone: none → xena-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/799451
Committed: https://opendev.org/openstack/tripleo-validations/commit/e610926e80e2841fc6c7459ef295c1dec4df0eed
Submitter: "Zuul (22348)"
Branch: master

commit e610926e80e2841fc6c7459ef295c1dec4df0eed
Author: Christopher Brown <email address hidden>
Date: Mon Jul 5 19:49:15 2021 +1000

    Corrected the task 'Get file_descriptors total_limit' to get the
    'fs.file-max' value.

    Closes-Bug: #1934656
    Change-Id: I3a54abe72a68da04c57c05a71e4eace93225f058

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/802247

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/802248

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/802249

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-validations (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-validations/+/802250

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/802248
Committed: https://opendev.org/openstack/tripleo-validations/commit/f9dcec50cf8ce6bac82984a6b4b0a99f50932006
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit f9dcec50cf8ce6bac82984a6b4b0a99f50932006
Author: Christopher Brown <email address hidden>
Date: Mon Jul 5 19:49:15 2021 +1000

    Corrected the task 'Get file_descriptors total_limit' to get the
    'fs.file-max' value.

    Closes-Bug: #1934656
    Change-Id: I3a54abe72a68da04c57c05a71e4eace93225f058
    (cherry picked from commit e610926e80e2841fc6c7459ef295c1dec4df0eed)

tags: added: in-stable-victoria
tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/802247
Committed: https://opendev.org/openstack/tripleo-validations/commit/c4f0f77f048d03b886545dc13bdddded88c11f04
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c4f0f77f048d03b886545dc13bdddded88c11f04
Author: Christopher Brown <email address hidden>
Date: Mon Jul 5 19:49:15 2021 +1000

    Corrected the task 'Get file_descriptors total_limit' to get the
    'fs.file-max' value.

    Closes-Bug: #1934656
    Change-Id: I3a54abe72a68da04c57c05a71e4eace93225f058
    (cherry picked from commit e610926e80e2841fc6c7459ef295c1dec4df0eed)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/802250
Committed: https://opendev.org/openstack/tripleo-validations/commit/379eae2f6ab5ec41f1a180535d4abfa964cd881b
Submitter: "Zuul (22348)"
Branch: stable/train

commit 379eae2f6ab5ec41f1a180535d4abfa964cd881b
Author: Christopher Brown <email address hidden>
Date: Mon Jul 5 19:49:15 2021 +1000

    Corrected the task 'Get file_descriptors total_limit' to get the
    'fs.file-max' value.

    Closes-Bug: #1934656
    Change-Id: I3a54abe72a68da04c57c05a71e4eace93225f058
    (cherry picked from commit e610926e80e2841fc6c7459ef295c1dec4df0eed)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 14.2.1

This issue was fixed in the openstack/tripleo-validations 14.2.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 13.4.1

This issue was fixed in the openstack/tripleo-validations 13.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-validations (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/tripleo-validations/+/802249
Committed: https://opendev.org/openstack/tripleo-validations/commit/77581d42f9f5c7d74178127349ac6bb10d3d7f92
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 77581d42f9f5c7d74178127349ac6bb10d3d7f92
Author: Christopher Brown <email address hidden>
Date: Mon Jul 5 19:49:15 2021 +1000

    Corrected the task 'Get file_descriptors total_limit' to get the
    'fs.file-max' value.

    Closes-Bug: #1934656
    Change-Id: I3a54abe72a68da04c57c05a71e4eace93225f058
    (cherry picked from commit e610926e80e2841fc6c7459ef295c1dec4df0eed)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations 15.1.0

This issue was fixed in the openstack/tripleo-validations 15.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations ussuri-eol

This issue was fixed in the openstack/tripleo-validations ussuri-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-validations train-eol

This issue was fixed in the openstack/tripleo-validations train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.