[OVN]ControllerAgent cannot be changed to ControllerGatewayAgent dynamically

[ZhouHeng]

I have 3 nodes. NodeA, NodeB, NodeC.

I execute cmd 'ovs-vsctl set open_vswitch . external-ids:ovn-cms-options=enable-chassis-as-gw' in NodeA and NodeV, as gateway Node.

show agent list by executing the command 'openstack network agent list':

NodeA is 'OVN Controller Gatewaty agent'
NodeB is 'OVN Controller Gatewaty agent'
NodeC is 'OVN Controller agent'

the result is the same as I expected.

next I execute cmd 'ovs-vsctl set open_vswitch . external-ids:ovn-cms-options=enable-chassis-as-gw' in NodeC,

show agent list by executing the command 'openstack network agent list':

NodeA is 'OVN Controller Gatewaty agent'
NodeB is 'OVN Controller Gatewaty agent'
NodeC is 'OVN Controller agent'

The NodeC is still 'OVN Controller agent', not 'OVN Controller Gatewaty agent', The command has been executed many times and the result is still unchanged.

But as long as I execute the command to restart the neutron service, the result will be correct. NodeC is 'OVN Controller Gatewaty agent'.

Similarly, the 'OVN Controller Gatewaty agent' cannot be turned into 'OVN Controller agent' without restarting the neutron service.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/800278

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/800278
Committed: https://opendev.org/openstack/neutron/commit/9cffd7b3223c2e8c88129c79aa62c255350c55d4
Submitter: "Zuul (22348)"
Branch: master

commit 9cffd7b3223c2e8c88129c79aa62c255350c55d4
Author: Elvira García <email address hidden>
Date: Fri Jul 9 17:55:56 2021 +0200

    [OVN] Change ControllerAgent type dinamically

    The ControllerAgent class now changes in Openstack when changing the
    type of an agent in its ovsdb table. This is possible thanks to adding a
    new condition to the event that triggered the update of the AgentCache.
    If the right external_ids changed, a new agent with the correct class
    will replace the old one in the AgentCache. Also adds functional
    tests to check this.

    Closes-Bug: #1934420

    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I75380c455864aa055e8049a6beff8619687b52ce

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/neutron/+/814654

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/814654
Committed: https://opendev.org/openstack/neutron/commit/13c0287ac7b50dff522785e1079426f8e718eb7f
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 13c0287ac7b50dff522785e1079426f8e718eb7f
Author: Elvira García <email address hidden>
Date: Fri Jul 9 17:55:56 2021 +0200

    [OVN] Change ControllerAgent type dinamically

    The ControllerAgent class now changes in Openstack when changing the
    type of an agent in its ovsdb table. This is possible thanks to adding a
    new condition to the event that triggered the update of the AgentCache.
    If the right external_ids changed, a new agent with the correct class
    will replace the old one in the AgentCache. Also adds functional
    tests to check this.

    Closes-Bug: #1934420

    Signed-off-by: Elvira García <email address hidden>
    Change-Id: I75380c455864aa055e8049a6beff8619687b52ce
    (cherry picked from commit 9cffd7b3223c2e8c88129c79aa62c255350c55d4)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/822307

[OpenStack Infra (hudson-openstack)]

Change abandoned by "yatin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/822307
Reason: Based on last comment

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.2.0 release.