tripleoclient - constants.OVERCLOUD_NETWORKS_FILE not used when jinja2 rendering templates

[Harald Jensås]

The default in THT is used, instead of the default in tripleoclient when no 'parsed_args.networks_file is not used. The default in THT/tools/process-templates.py is used instead. This worked differently prior to Ic9db8d852fbfa50f4ac574ebe524c1fb1d85c588, when the tripleo constant was used.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/798744

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/798744
Committed: https://opendev.org/openstack/python-tripleoclient/commit/a586cb7795cf301c968fafa2e6fd9e5201220977
Submitter: "Zuul (22348)"
Branch: master

commit a586cb7795cf301c968fafa2e6fd9e5201220977
Author: Harald Jensås <email address hidden>
Date: Tue Jun 29 21:26:18 2021 +0200

    Honor role and networks file constants

    Prior to change Ic9db8d852fbfa50f4ac574ebe524c1fb1d85c588
    the tripleoclient constants OVERCLOUD_ROLES_FILE and
    OVERCLOUD_NETWORKS_FILE was used as the defaults.

    This was changed to use the defaults in process-templates.py

    This restores the previous behaviour, honoring the tripleoclient
    constants.

    Closes-Bug: #1934010
    Change-Id: Ie133a6718ca50f30fee7a48fc83ff0e89d84d2dc

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/799056

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/799056
Committed: https://opendev.org/openstack/python-tripleoclient/commit/2ac670653640630c83d204ca53744553ef799390
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 2ac670653640630c83d204ca53744553ef799390
Author: Harald Jensås <email address hidden>
Date: Tue Jun 29 21:26:18 2021 +0200

    Honor role and networks file constants

    Prior to change Ic9db8d852fbfa50f4ac574ebe524c1fb1d85c588
    the tripleoclient constants OVERCLOUD_ROLES_FILE and
    OVERCLOUD_NETWORKS_FILE was used as the defaults.

    This was changed to use the defaults in process-templates.py

    This restores the previous behaviour, honoring the tripleoclient
    constants.

    Closes-Bug: #1934010
    Change-Id: Ie133a6718ca50f30fee7a48fc83ff0e89d84d2dc
    (cherry picked from commit a586cb7795cf301c968fafa2e6fd9e5201220977)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 16.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 17.1.0 release.