Styling on eg-org-select box to show required-ness

[Tiffany Little]

In the new Angular forms, it can now pick up which fields are required from the fieldmapper and show a red indicator to show that the field is required. However, there is often/usually a box for an org select that *is* required, but there's no styling to show it.

It would be good if we could add similar styling around eg-org-select boxes to show that they're required.

[Tiffany Little (tslittle)]

Here's a patch to do this: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/tlittle/LP1933498_orgselectrequired

[Galen Charlton (gmc)]

Unless I'm missing something, the patch would display all OU selectors as being required.

It's not common, but there are some cases where an OU field is optional, including the bib record owner and line item details owning library. Consequently, I think eg-org-select would need to get a "required" or "mandatory" @Input that eg-fm-record-editor can use so that requiredness can be dynamic, so to speak.

[Tiffany Little (tslittle)]

Good point.

Follow-up commit: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=c2535997f039726b43f3969f9059943452fbd885

Since it's most common that org-select should be required, this makes it required unless otherwise specified.

[Tiffany Little (tslittle)]

P.S. For anyone testing this during Sept 2021 Bug squashing, I've explicitly set the Angular Load MARC Order Records Ordering Agency box to required=false to show that it can be unset when needed.

[Galen Charlton (gmc)]

I would suggest a different approach in the interest of consistency:

- Make the default value of the required @Input be false; no other custom widget defaults to required, nor do native HTML inputs.
- Update fm-editor to have it check field.isRequired() to set "required" for eg-org-select.