The 'tripleoclient.export.export_passwords' function always exports all generated passwords.

[Jiri Podivin]

Behavior of the 'tripleoclient.export.export_passwords' no longer corresponds to the intent estblished by it's signature.

https://opendev.org/openstack/python-tripleoclient/src/branch/master/tripleoclient/export.py#L34-L51

Original function had a mechanism for excluding passwords from export.

However, the check was first refactored in [1] and finally completely abandoned in [2].

Since then the only remnant of the check is the unused 'excludes' argument, which defaults
to True, regular expression check, and a double nested loop iterating over all password param names.

Meanwhile, all generated passwords are exported every time.

Two options present themselves.

Removal of the remnants of the check mechanism. Or its reestablishment.

[1] - https://review.opendev.org/c/openstack/python-tripleoclient/+/745958
[2] - https://review.opendev.org/c/openstack/python-tripleoclient/+/773287

[Jiri Podivin (jpodivin)]

After consultation with James Slagle, the second option was chosen.

[Jiri Podivin (jpodivin)]

The patch is now in gerrit.
https://review.opendev.org/c/openstack/python-tripleoclient/+/797461

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/797461
Committed: https://opendev.org/openstack/python-tripleoclient/commit/cc2ac4a855ffeb51d9c854cd0a5c4f75f2cb735c
Submitter: "Zuul (22348)"
Branch: master

commit cc2ac4a855ffeb51d9c854cd0a5c4f75f2cb735c
Author: Jiri Podivin <email address hidden>
Date: Tue Jun 22 15:27:28 2021 +0200

    Restoration of the 'export_passwords' exclusion

    The 'tripleoclient.export.export_passwords' function was intended
    export passwords selectively, if needed, based on provided rules.

    This patch restores that functionality.
    Furthermore, tests were adjusted to validate exports with and
    without filtering.

    Function level documentation was expanded with information about
    inputs and outputs.

    Per suggestion, the loop was adjusted to iterate over generated passwords
    rather than over `tripleo_common_constants.PASSWORD_PARAMETER_NAMES`.
    The existing import of tripleo_common.constants was removed, as there
    were no more references to it.

    Closes-Bug: #1933237

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I397caaf314dae17a48d4aeed55f1a5a8e4ae3d41

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 17.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/838911

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/838911
Committed: https://opendev.org/openstack/python-tripleoclient/commit/095182c143336bb4b7039df411ad47f7b64bd4bf
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 095182c143336bb4b7039df411ad47f7b64bd4bf
Author: Jiri Podivin <email address hidden>
Date: Tue Jun 22 15:27:28 2021 +0200

    Restoration of the 'export_passwords' exclusion

    The 'tripleoclient.export.export_passwords' function was intended
    export passwords selectively, if needed, based on provided rules.

    This patch restores that functionality.
    Furthermore, tests were adjusted to validate exports with and
    without filtering.

    Function level documentation was expanded with information about
    inputs and outputs.

    Per suggestion, the loop was adjusted to iterate over generated passwords
    rather than over `tripleo_common_constants.PASSWORD_PARAMETER_NAMES`.
    The existing import of tripleo_common.constants was removed, as there
    were no more references to it.

    Closes-Bug: #1933237

    Signed-off-by: Jiri Podivin <email address hidden>
    Change-Id: I397caaf314dae17a48d4aeed55f1a5a8e4ae3d41
    (cherry picked from commit cc2ac4a855ffeb51d9c854cd0a5c4f75f2cb735c)