neutron_tempest_plugin.api.test_subnets.SubnetServiceTypeTestJSON.test_allocate_ips_are_from_correct_subnet fails with Unrecognized attribute(s) 'service_types'

[Ananya Banerjee]

neutron_tempest_plugin.api.test_subnets.SubnetServiceTypeTestJSON fails with

Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/neutron_tempest_plugin/api/test_subnets.py", line 91, in test_allocate_ips_are_from_correct_subnet
    cidr=str(cidr_1))
  File "/usr/lib/python3.6/site-packages/neutron_tempest_plugin/api/base.py", line 465, in create_subnet
    **kwargs)
  File "/usr/lib/python3.6/site-packages/neutron_tempest_plugin/services/network/json/network_client.py", line 145, in _create
    resp, body = self.post(uri, post_data)
  File "/usr/lib/python3.6/site-packages/tempest/lib/common/rest_client.py", line 299, in post
    return self.request('POST', url, extra_headers, headers, body, chunked)
  File "/usr/lib/python3.6/site-packages/tempest/lib/common/rest_client.py", line 703, in request
    self._error_checker(resp, resp_body)
  File "/usr/lib/python3.6/site-packages/tempest/lib/common/rest_client.py", line 814, in _error_checker
    raise exceptions.BadRequest(resp_body, resp=resp)
tempest.lib.exceptions.BadRequest: Bad request
Details: {'type': 'HTTPBadRequest', 'message': "Unrecognized attribute(s) 'service_types'", 'detail': ''}

https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/be01c1e/logs/undercloud/var/log/tempest/stestr_results.html.gz

https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/446d107/logs/undercloud/var/log/tempest/stestr_results.html.gz

[Marios Andreou (marios-b)]

don't know why it wasn't picked up by the bots but as a temporary measure the test was added to skiplist with https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/797320

[Ananya Banerjee (frenzyfriday)]

Looks like it started failing after this got merged - https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/787718 .

Do we need to add "subnet_types" here maybe - https://opendev.org/openstack/openstacksdk/src/branch/master/openstack/network/v2/subnet.py#L30

[Marios Andreou (marios-b)]

reviewing the master integration line today I noticed the periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master is still failing for this at [1][2][3]

I think the skip at https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/797320/2#message-c25b3c9d626654e2772f41774c4363c516fd80bd needs tweaking posting a fixup now

[1] https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/f154efc/logs/undercloud/var/log/tempest/stestr_results.html.gz
[2] https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/e7cea89/logs/undercloud/var/log/tempest/stestr_results.html.gz
[3] https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/916d4bf/logs/undercloud/var/log/tempest/stestr_results.html.gz

[Marios Andreou (marios-b)]

https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/798068

[Marios Andreou (marios-b)]

so the fix at comment #4 actually causes the skip to happen now with a green run there https://review.opendev.org/c/openstack/openstack-tempest-skiplist/+/798068/1#message-3e4207c2cb50bff233534ffb0bdc9862bdc03f16

I am just uncomfortable skipping these tests. Does this mean we are promoting broken content?

Thinking about it a bit i guess the key thing is for this same issue to block the relevant component. In this case possibly networking for example. i.e. networking component line will only give us new content when it is working again since it is broken/blocked on the same issue. . so in the meantime it is not relevant for the integration line we are 'locked' on the older component content until it is fixed and can promote again.

[wes hayutin (weshayutin)]

RE:
I am just uncomfortable skipping these tests. Does this mean we are promoting broken content?

The process is that we can promote builds with failing tempest tests as long as we have the CIX logged. We can not hold builds for any tempest test. If you feel this particular test is critical enough to hold the build, then we can have the conversation.

Looking at
https://logserver.rdoproject.org/openstack-periodic-integration-main/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/f154efc/logs/undercloud/var/log/tempest/stestr_results.html.gz

I would strongly suggest that we do NOT hold the build for these results:
Status: Pass 1419 Failure 1 Skip 149

[Slawek Kaplonski (slaweq)]

@Marios: in this specific case, that was more issue with Neutron API extensions which I enabled/disabled for OVN backend and it should be fixed soon with https://review.opendev.org/c/openstack/neutron/+/797595
So for now skipping this test is valid workaround for me as that is what actually should be done when this API extension isn't available.

[chandan kumar (chkumar246)]

https://review.opendev.org/c/openstack/neutron/+/797595 is merged now. It is tested here
https://review.rdoproject.org/r/c/testproject/+/34332

- https://logserver.rdoproject.org/32/34332/1/check/periodic-tripleo-ci-centos-8-standalone-full-tempest-api-master/9cda58e/logs/undercloud/var/log/tempest/tempest_run.log.txt.gz

```
{2} setUpClass (neutron_tempest_plugin.api.test_subnets.SubnetServiceTypeTestJSON) ... SKIPPED: subnet-service-types extension not enabled.
```

I think we can close this bug with fix released.

[Slawek Kaplonski (slaweq)]

It should be fixed in Neutron now with https://review.opendev.org/c/openstack/neutron/+/797595

[Ronelle Landy (rlandy)]

entry is no longer in the skiplist - closing out