tripleo-upgrade fail to create workload related script when using tags.

[Sofer Athlan-Guyot]

Hi,

using this command:

infrared tripleo-upgrade --undercloud-update yes --overcloud-update yes --overcloud-stack qe-Cloud-0 --updates-workarounds yes --upgrade-workload yes --ansible-args="tags=create_undercloud_update_scripts,create_overcloud_update_scripts" --upgrade-floatingip-check yes

I'm using tags that should only create the scripts without running any action from the tripleo-upgrade role.

Running this on a fresh deployment leads to:

TASK [tripleo-upgrade : launch workload] *************************************************************************************************************************************************************************************************************[495/1889]
fatal: [undercloud-0]: FAILED! => {"changed": true, "cmd": "set -o pipefail\n/home/stack/workload_launch.sh 2>&1 | awk '{ print strftime(\"%Y-%m-%d %H:%M:%S |\"), $0; fflush(); }' >> workload_launch.log\n", "delta": "0:00:00.007562", "end": "2021-06-16 09:
46:56.486218", "msg": "non-zero return code", "rc": 127, "start": "2021-06-16 09:46:56.478656", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

see the 127 er code, the script workload_launch.sh is not created.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-upgrade/+/796621

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-upgrade/+/796621
Committed: https://opendev.org/openstack/tripleo-upgrade/commit/1d854f6d53728be42f0bfe62029b2b2b03b435eb
Submitter: "Zuul (22348)"
Branch: master

commit 1d854f6d53728be42f0bfe62029b2b2b03b435eb
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Jun 16 11:56:57 2021 +0200

    Make sure create_workload tasks inherit the always tags.

    Dynamicly included tasks don't inherits tags from the parent
    include_task, only import does this. In order to not use import and
    still have inheritence, we need to use the "apply" workaround[1]

    [1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_tags.html#tag-inheritance-for-includes-blocks-and-the-apply-keyword

    Change-Id: I86d15adfa5f685fc0cd62a624ca0219566a02e22
    Closes-Bug: 1932139

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-upgrade 10.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-upgrade/+/873271

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-upgrade/+/873271
Committed: https://opendev.org/openstack/tripleo-upgrade/commit/07caa7fde6114331914b6fd2fafb22b9e21a7e11
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 07caa7fde6114331914b6fd2fafb22b9e21a7e11
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Jun 16 11:56:57 2021 +0200

    Make sure create_workload tasks inherit the always tags.

    Dynamicly included tasks don't inherits tags from the parent
    include_task, only import does this. In order to not use import and
    still have inheritence, we need to use the "apply" workaround[1]

    [1] https://docs.ansible.com/ansible/latest/user_guide/playbooks_tags.html#tag-inheritance-for-includes-blocks-and-the-apply-keyword

    Change-Id: I86d15adfa5f685fc0cd62a624ca0219566a02e22
    Closes-Bug: 1932139
    (cherry picked from commit 1d854f6d53728be42f0bfe62029b2b2b03b435eb)