2.3.4+dfsg.1-2 is FTBFS

[Robert Ancell]

Fails to build due to the terminal being too small:

 notcurses 2.3.4 by nick black et al on XTerm
  20 rows 76 cols (23.75KiB) 48B crend 8 colors
  compiled with gcc-10.3.0, 16B little-endian cells
  terminfo from ncurses 6.2.20201114
  avformat 58.45.100 avutil 56.51.100 swscale 5.7.100
...
At least an 76x24 terminal is required (current: 76x20)

This is due to the build server simulating an 24x80 terminal, and the test running with a margin of 2, which causes it to be too small. Proposed solution is to only use left and right margins to leave enough rows to run the test.

[Robert Ancell (robert-ancell)]

Fix is to replace debian/test/control:

# Execute notcurses-demo with:
# -c: seed PRNG with known constant for semi-reproducible timings
# -m2: use 2-cell margins on all sides (to test margins)
# -d0: delay multiplier of 0 (no artificial delays)
Test-Command: TERM=xterm notcurses-demo -c -m2 -d0
Depends: notcurses-bin
Restrictions: allow-stderr, flaky
Features: test-name=demo

with:

# Execute notcurses-demo with:
# -c: seed PRNG with known constant for semi-reproducible timings
# -m0,2,0,2: use 2-cell margins on left and right sides (to test margins)
# -d0: delay multiplier of 0 (no artificial delays)
Test-Command: TERM=xterm notcurses-demo -c -m0,2,0,2 -d0
Depends: notcurses-bin
Restrictions: allow-stderr, flaky
Features: test-name=demo

[Robert Ancell (robert-ancell)]

There may also be a means of making the simulated terminal bigger on the build server, but I don't know how to do that.

[nick black (dankamongmen)]

How embarrassing -- thanks a lot for the heads-up! I think the best way to fix this will be to do so in the Debian package in Unstable, which I assume is how this is reaching Ubuntu. Sound good? This would target 2.3.4+dfsg-3, and I can have it uploaded to Debian Unstable within the hour.

[nick black (dankamongmen)]

I of course mean 2.3.4+dfsg.1-3.

[nick black (dankamongmen)]

https://salsa.debian.org/debian/notcurses/-/commit/30a0e9d39eb45acca5292c85ee2cd154f275e1f9

building new package now.

[nick black (dankamongmen)]

ooooh my patch dropped the -m2 entirely, but i like your -m0,2,0,2 solution, nice. i'll use that instead!

[nick black (dankamongmen)]

https://salsa.debian.org/debian/notcurses/-/commit/d73556faadfd08013b03ccedbd7348edbddab53e

[nick black (dankamongmen)]

[schwarzgerat](0) $ dput *.changes
Trying to upload package to ftp-master (ftp.upload.debian.org)
Checking signature on .changes
gpg: /home/dank/src/dsscaw/notcurses_2.3.4+dfsg.1-3_source.changes: Valid signature from 5F43400C21CBFACC
Checking signature on .dsc
gpg: /home/dank/src/dsscaw/notcurses_2.3.4+dfsg.1-3.dsc: Valid signature from 5F43400C21CBFACC
Uploading to ftp-master (via ftp to ftp.upload.debian.org):
  Uploading notcurses_2.3.4+dfsg.1-3.dsc: done.
  Uploading notcurses_2.3.4+dfsg.1.orig.tar.xz: done.
  Uploading notcurses_2.3.4+dfsg.1-3.debian.tar.xz: done.
  Uploading notcurses_2.3.4+dfsg.1-3_source.buildinfo: done.
  Uploading notcurses_2.3.4+dfsg.1-3_source.changes: done.
Successfully uploaded packages.
[schwarzgerat](0) $

[nick black (dankamongmen)]

by the way @robert-ancell, i notice that you have ",flaky" in there. this isn't present in the Debian package. has it been added in Ubuntu?

[nick black (dankamongmen)]

https://buildd.debian.org/status/package.php?p=notcurses&suite=sid

[nick black (dankamongmen)]

All built, uploaded to the archive. This ought flow to Ubuntu soon enough. Thanks again!

[nick black (dankamongmen)]

Present in Debian Unstable.

[Robert Ancell (robert-ancell)]

Thanks very much Nick! We should be in-sync with Debian, so I don't think the ",flaky" was added in Ubuntu. However, I'm not too familiar with this package so not 100% sure if something automated has added those.

[nick black (dankamongmen)]

[schwarzgerat](0) $ apt-show-versions notcurses-bin
notcurses-bin:amd64/unstable 2.3.4+dfsg.1-3 uptodate
[schwarzgerat](0) $

[Robert Ancell (robert-ancell)]

There seems to be a bug in the fix, the test is failing:
https://autopkgtest.ubuntu.com/results/autopkgtest-impish/impish/amd64/n/notcurses/20210616_142532_8cc55@/log.gz

Seems to be missing the '-' for the '-m':
autopkgtest [14:22:49]: test demo: TERM=xterm notcurses-demo -c m0,2,0,2 -d0
Invalid demo specification: 0

[nick black (dankamongmen)]

Agreed, and I can now reproduce this failure locally. Tracking in https://github.com/dankamongmen/notcurses/issues/1784. Thanks!

[nick black (dankamongmen)]

with the Debian freeze ending, i've reenabled this autopkgtest and am putting up a candidate package now.

[nick black (dankamongmen)]

fwiw, i can no longer reproduce this locally, though i also can't point at any particular commit that ought have fixed it =/.

[nick black (dankamongmen)]

Alright, the impish release still has 2.3.13+dfsg.1-1, but as soon as 2.3.13+dfsg.1-2, we'll know whether this is still a problem. All autopkgtests have succeeded within the Debian build infrastructure.

[nick black (dankamongmen)]

hrmmm, new versions don't seem to be entering Impish. is that due to something changing since the release of Debian Bullseye, or is notcurses misbehaving on Ubuntu CI?

[nick black (dankamongmen)]

Ahhh, it was due to the Impish Debian freeze. Well, we'll know soon enough!

[nick black (dankamongmen)]

2.4.9 is present in Jellyfish, so things seem to be working fine now.

[Dan Bungert (dbungert)]

This seems to be resolved, closing. If that is in error please reopen.