baremtal deploy generated env does not work for custom --templates

[Harald Jensås]

When using openstack overcloud node provision, openstack overcloud network provison and openstack overcloud network vip provision the generated environment files hard-code the resource registry to point at files in /usr/share/openstack-tripleo-heat-tempaltes.

This does not work when the user specified a different THT root using the '--templates' argument.

2021-06-15 15:17:45.359 699868 ERROR openstack [-] Could not fetch contents for file:///home/stack/tripleo-heat-templates/network/ports/deployed_storage_mgmt_cloud_0.yaml: heatclient.exc.CommandError: Could not fetch contents for file:///home/stack/tripleo-heat-templates/network/ports/deployed_storage_mgmt_cloud_0.yaml

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/796545

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/796546

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Harald Jensås <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/796545
Reason: Let's add '--templates' option to all commands and write the correct templates path from the start.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Harald Jensås <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/796546
Reason: Will add --templates option to commands instead. See review comments on the depends-on.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/798370

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/798371

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/798370
Committed: https://opendev.org/openstack/tripleo-ansible/commit/af92fbc650f74766e9a29a447be807c1e21418af
Submitter: "Zuul (22348)"
Branch: master

commit af92fbc650f74766e9a29a447be807c1e21418af
Author: Harald Jensås <email address hidden>
Date: Mon Jun 28 17:21:21 2021 +0200

    Add option to set template paths in env population

    Overcloud node and network provisioning plays currently
    write environment files with a hard coded THT-root path.

    Add 'templates' parameter to the modules so that the user
    can specify the templates path.

    Related-Bug: #1932079
    Change-Id: I9decd8fb9860cd17dc9e69b9970d9f9dabf11428

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/799142

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/799142
Committed: https://opendev.org/openstack/tripleo-ansible/commit/c7136d06fc0cf935679a5cf4765c9eef07054131
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit c7136d06fc0cf935679a5cf4765c9eef07054131
Author: Harald Jensås <email address hidden>
Date: Mon Jun 28 17:21:21 2021 +0200

    Add option to set template paths in env population

    Overcloud node and network provisioning plays currently
    write environment files with a hard coded THT-root path.

    Add 'templates' parameter to the modules so that the user
    can specify the templates path.

    Related-Bug: #1932079
    Change-Id: I9decd8fb9860cd17dc9e69b9970d9f9dabf11428
    (cherry picked from commit af92fbc650f74766e9a29a447be807c1e21418af)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/798371
Committed: https://opendev.org/openstack/python-tripleoclient/commit/9c997ff0945e2771a857c6859120af381d480505
Submitter: "Zuul (22348)"
Branch: master

commit 9c997ff0945e2771a857c6859120af381d480505
Author: Harald Jensås <email address hidden>
Date: Mon Jun 28 17:49:37 2021 +0200

    Add '--templates' arg to node and net provision

    Allow setting '--templates', the path tot the THT root
    directory. Environment files created by the node and
    network provision commands will be created with the user
    specified path to the THT root. Defaults to:
     /usr/share/openstack-tripleo-heat-templates/

    Closes-Bug: #1932079
    Depends-On: I9decd8fb9860cd17dc9e69b9970d9f9dabf11428
    Change-Id: I5dd81788c08bb0d797190a5fb8bb120b7d8b4f32

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/799255

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/python-tripleoclient/+/799255
Committed: https://opendev.org/openstack/python-tripleoclient/commit/4e097d5409d6b992fcb2e6121241a22e76313fba
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 4e097d5409d6b992fcb2e6121241a22e76313fba
Author: Harald Jensås <email address hidden>
Date: Mon Jun 28 17:49:37 2021 +0200

    Add '--templates' arg to node and net provision

    Allow setting '--templates', the path tot the THT root
    directory. Environment files created by the node and
    network provision commands will be created with the user
    specified path to the THT root. Defaults to:
     /usr/share/openstack-tripleo-heat-templates/

    Closes-Bug: #1932079
    Depends-On: I9decd8fb9860cd17dc9e69b9970d9f9dabf11428
    Change-Id: I5dd81788c08bb0d797190a5fb8bb120b7d8b4f32
    (cherry picked from commit 9c997ff0945e2771a857c6859120af381d480505)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 16.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 17.1.0 release.