Add UI support for VMFS7

[Lee Trager]

VMWare ESXi 7.0 uses a new on disk layout. As such I had to create a new storage layout in MAAS for it, VMFS7. Like VMFS6 this layout has a number of partitions reserved for OS use which cannot be modified. The difference being that in VMFS7 partitions 1-7 are reserved for OS usage and partition 8 and above can be used for a user defined datastore.

The team is planning on backporting VMFS7 to MAAS 3.0.1, the UI will need to be backported as well.

[Caleb Ellis (caleb-ellis)]

My understanding of this issue is that the UI should add an option to change storage layout to VMFS7, however when I use the machine.apply_storage_layout websocket method I get the error:

{
  "size": ["Ensure this value is greater than or equal to 4194304."]
}

No other storage layout option requires a size, and even if I do provide a valid size parameter the error is always the same.

Is there something else I should be doing in regards to adding UI support for VMFS7 (beyond of course making sure the machine storage tab displays VMFS7 partitions correctly)?

[Adam Collard (adam-collard)]

{'method': 'machine.apply_storage_layout', 'type': 0, 'params': {'storage_layout': 'vmfs7', 'system_id': 'baxred'}, 'request_id': 13}

[Adam Collard (adam-collard)]

The error you're getting is (I suspect) because you're trying to apply VMFS7 layout to a machine that doesn't have a boot disk that's big enough - notably VMFS7 requires a 32Gb boot disk.

In my testing on machines in bolla, they were not big enough - but MAAS wasn't properly validating that.

In the attached MP, MAAS will now report "Boot disk must be at least 32Gb" when attempting to apply the layout (with an error keyed under "boot_size")

VMFS6 requires 10G but was erroneously checking for 1G