managed=false nodes fail network-v2 port provisioning

[Harald Jensås]

When provisoning to unmanged (pre-provisioned) servers, the node port creation fails.

"Traceback (most recent call last):\n
  File \"/tmp/ansible_tripleo_overcloud_network_ports_payload_e2yebdfe/ansible_tripleo_overcloud_network_ports_payload.zip/ansible/modules/tripleo_overcloud_network_ports.py\", line 604, in run_module\n
  File \"/tmp/ansible_tripleo_overcloud_network_ports_payload_e2yebdfe/ansible_tripleo_overcloud_network_ports_payload.zip/ansible/modules/tripleo_overcloud_network_ports.py\", line 494, in manage_instances_ports\n
  File \"/usr/lib64/python3.6/concurrent/futures/thread.py\", line 56, in run\n
    result = self.fn(*self.args, **self.kwargs)\n
  File \"/tmp/ansible_tripleo_overcloud_network_ports_payload_e2yebdfe/ansible_tripleo_overcloud_network_ports_payload.zip/ansible/modules/tripleo_overcloud_network_ports.py\", line 385, in _provision_ports\n
  File \"/tmp/ansible_tripleo_overcloud_network_ports_payload_e2yebdfe/ansible_tripleo_overcloud_network_ports_payload.zip/ansible/modules/tripleo_overcloud_network_ports.py\", line 331, in generate_port_defs\n
  TypeError: sequence item 1: expected str instance, NoneType found\n",

The issue is that the ctlplane does not have the tag: tripleo_network_name, so the net_id_map[1] get's a None value.

[1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/module_utils/network_data_v2.py#L484

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/794903

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/794903
Committed: https://opendev.org/openstack/tripleo-ansible/commit/fc0be3eb69b94aefe7e0425ef5a818df96076e61
Submitter: "Zuul (22348)"
Branch: master

commit fc0be3eb69b94aefe7e0425ef5a818df96076e61
Author: Harald Jensås <email address hidden>
Date: Fri Jun 4 23:39:20 2021 +0200

    Default net name upper to name lower in net maps

    If the network does not have the tripleo_network_name
    tag set, default the "name_upper" net.name.

    Closes-Bug: #1930936
    Change-Id: I3f89898227db8649a8937f65fd5e0cc8626cd803

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-ansible/+/795459

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 4.0.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-ansible/+/795459
Committed: https://opendev.org/openstack/tripleo-ansible/commit/995fb0b12dcb5f73f820660399a764e254a5f5ce
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 995fb0b12dcb5f73f820660399a764e254a5f5ce
Author: Harald Jensås <email address hidden>
Date: Fri Jun 4 23:39:20 2021 +0200

    Default net name upper to name lower in net maps

    If the network does not have the tripleo_network_name
    tag set, default the "name_upper" net.name.

    Closes-Bug: #1930936
    Change-Id: I3f89898227db8649a8937f65fd5e0cc8626cd803
    (cherry picked from commit fc0be3eb69b94aefe7e0425ef5a818df96076e61)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 3.2.0 release.