Allow to run rsyncd without xinetd

[Alfredo Moralejo]

CetnOS Stream 9 preview does not provide xinetd package. puppet-swift configures rsync server to use xinetd by default and apparently there is no easy option to configure to not use it in some places:

https://github.com/openstack/puppet-swift/blob/492702370e78338b2053eda522636446df8e64be/manifests/ringserver.pp#L38

https://github.com/openstack/puppet-swift/blob/492702370e78338b2053eda522636446df8e64be/manifests/storage/all.pp#L174-L176 (does not makes use_xinetd option in swift::storage to swift::storage::all.

Note that since centos8 rsyncd daemon needs to install rsync-daemon package which is not handled by puppetlabs-rsync. I've sent PR for this:

https://github.com/puppetlabs/puppetlabs-rsync/pull/139

[Joel Capitao (jcapitao)]

I've proposed a patch: https://review.opendev.org/c/openstack/puppet-swift/+/795832

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/795832
Committed: https://opendev.org/openstack/puppet-swift/commit/053a3a2a56723e0ec43d1855ac7615657a4de8f0
Submitter: "Zuul (22348)"
Branch: master

commit 053a3a2a56723e0ec43d1855ac7615657a4de8f0
Author: Joel Capitao <email address hidden>
Date: Tue Jun 8 17:25:31 2021 +0200

    Add 'rsync_use_xinetd' as argument to swift::ringserver

    Since in RHEL/CentOS >= 8 rsyncd systemd unit is shipped in a
    different package (rsync-dameon), we need to be able to not
    use xinetd to manage rsync service.
    The dependency on rsync-daemon for RHEL/CentOS >= 8
    is handled in puppet-rsync with [1].

    [1] https://github.com/puppetlabs/puppetlabs-rsync/pull/139/files

    Closes-Bug: #1930855
    Change-Id: I85abf3811d61fa8bfc0a1607818d6495549b5a6b

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 19.4.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/puppet-swift/+/823757

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/puppet-swift/+/823757
Committed: https://opendev.org/openstack/puppet-swift/commit/b3576e78bfaeff7644dc37614613cef2df0661f0
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit b3576e78bfaeff7644dc37614613cef2df0661f0
Author: Joel Capitao <email address hidden>
Date: Tue Jun 8 17:25:31 2021 +0200

    Add 'rsync_use_xinetd' as argument to swift::ringserver

    Since in RHEL/CentOS >= 8 rsyncd systemd unit is shipped in a
    different package (rsync-dameon), we need to be able to not
    use xinetd to manage rsync service.
    The dependency on rsync-daemon for RHEL/CentOS >= 8
    is handled in puppet-rsync with [1].

    [1] https://github.com/puppetlabs/puppetlabs-rsync/pull/139/files

    Conflicts:
            manifests/params.pp

    Resolved conflict caused by 5b0745101a9af363e367ef301728541921a5a70d .

    Closes-Bug: #1930855
    Change-Id: I85abf3811d61fa8bfc0a1607818d6495549b5a6b
    (cherry picked from commit 053a3a2a56723e0ec43d1855ac7615657a4de8f0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-swift 18.5.0 release.