Circ modifier column appears twice in OPAC view

[Jeff Davis]

When you do a traditional catalog search in the client and view a record in OPAC View, the circ modifier column appears twice in the copy table. The Circulation Modifier column heading only appears once, so the remaining columns are all off by one.

The same issue appears in the Patron View tab in the Angular catalog, but only after you have done a traditional catalog search (otherwise the circ modifier column is hidden).

[Jeff Davis (jdavis-sitka)]

Here's a screenshot.

[Jeff Davis (jdavis-sitka)]

This only affects sites where OPAC view/patron view uses TPAC. Bootstrap OPAC is unaffected.

[Jeff Davis (jdavis-sitka)]

Working branch user/jeffdavis/lp1930308-duplicate-circ-modifier-column removes the extra circ_modifier data cell, which snuck in during an unrelated update:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/jeffdavis/lp1930308-duplicate-circ-modifier-column

To test:

1. Ensure your test environment is using TPAC.
2. Do a traditional catalog search and click on a record with holdings. Circ modifiers (if any) will appear twice in the copy table, and remaining fields in each row are incorrectly offset to the right.
3. Apply the fix.
4. Repeat step 2. The duplicate circ modifier field is now gone, and remaining fields are in the right place.

[Josh Stompro (u-launchpad-stompro-org)]

Tested this on Terran's Test Server 1 in TPAC mode.

Everything looks correct after following the testing steps. Only one Circ Modifier column is shown.

I tried the angular catalog, patron view also and it looks fine also.

I'll work on a signoff branch as soon as I can.
Josh

[Josh Stompro (u-launchpad-stompro-org)]

Signoff working branch at user/stompro/lp1930308-duplicate-circ-modifier-column-signoff

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1930308-duplicate-circ-modifier-column-signoff

Josh

[Galen Charlton (gmc)]

Pushed to master and rel_3_7. Thanks, Jeff and Josh!