Add a help popover on the patron bills screen for "Convert change to patron credit"

[Jane Sandberg]

The Patron bills screen has a modifier checkbox at the bottom called "Convert Change to Patron Credit"

This was brought up as a confusing concept that could use more information in an eg-help-popover next to the label.

Here are two possibilities for what the text could be, from Allison Pryor and April Durrence respectively:

"Instead of physical change handed back, patrons can choose to use it towards future payments"

"Applies any remaining amount after payment to the patron account for future use"

Thanks, Allison and April!

[Gina Monti (gmonti90)]

Here's my branch for the Circulation (Regular) module:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmonti/lp1929596_convert_patron_credit_help_popover

[Susan Morrison (smorrison425)]

Testing for bug squashing, I'm not able to see the help popover on terran-main, so I'm not sure if this was applied or if there was any issue with it. Sorry if I'm missing it.

[Terran McCanna (tmccanna)]

Sorry, that was my fault - please clear cache and try again!

[Susan Morrison (smorrison425)]

Thank you, Terran, I see it now. The alignment of the option and the popover is a tad off. Screenshot attached.

[Gina Monti (gmonti90)]

Sorry, the commit got messed up because of the line endings, but I added new div tags to keep it in line:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmonti/lp1929596_convert_patron_credit_help_popover

The real diff is:

Open-ILS/src/templates/staff/circ/patron/t_bills.tt2

   <eg-help-popover help-text="[% l('Applies any remaining amount after payment to the patron account for future use.') %]">
      </label>
    </div>
  </div>
+ <form class="flex-row" role="form">
- <form class="form-inline" role="form">
   <div class="checkbox">

Thing is I can't get the "# Copies" to align with everything else. Must be from how it labels the textbox for input.

[Terran McCanna (tmccanna)]

After comparing this to a test server without this patch, I see that the alignment was off before the popover was ever added. So, considering that, and that the slight misalignment looks better than the copy number box being pushed to a second line, I squashed Gina's 3 commits into one and changed the "flex-row" back to "form-inline".

My sign-off is at:
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/mccanna/lp1929596_convert_patron_credit_help_popover_signoff

[Jane Sandberg (sandbergja)]

Thanks, Gina and Terran! Merged to rel_3_11 and above.

[Gina Monti (gmonti90)]

Thanks, all, and sorry for the weirdly formatted commit!