The Grab and Drag Preference dialog displays ugly

Bug #192879 reported by Zhao Fan
6
Affects Status Importance Assigned to Milestone
Moblin Browser
Fix Released
Medium
Unassigned

Bug Description

Bug detailed description:
--------------------------
All content of the dialog displays in the middle, and there are big white space on both top and bottom of the dialog.

BTW, I am not sure if we need so many setting options expose to user. It's a little complicated to me on a handheld device.

Reproduce steps:
----------------
Choose menu Tools -> Grab and Drag Preferences.

Current result:
----------------
The dialog diaplays ugly.

Expected result:
----------------
The tabbar of the dialog should be on top of the dialog instead of the middle.

Basic root-causing log:
----------------------

Zhao Fan (fan-zhao)
Changed in moblin-browser:
assignee: nobody → carl-wong
importance: Undecided → Medium
Revision history for this message
cwong1 (carl-wong) wrote :

Jimmy, please look into it.

Changed in moblin-browser:
assignee: carl-wong → jimmyhuang
status: New → Confirmed
Revision history for this message
Jimmy Huang (jimmyhuang-deactivatedaccount) wrote :

Fan, I can take out some of the settings because a user may never need to change those, or possibly they'll never change any of them. Can you let me know what preferences from user's perspective that needs to stay, and I'll just remove the rest and make it look better. For example, the options, momentum, gestures, and advanced dialog can be taken out, and on the General dialog, we just leave the behavior and text toggle options. If you think of any ones that a user may want to change, then let me know.

Revision history for this message
Jimmy Huang (jimmyhuang-deactivatedaccount) wrote :

I cleaned up the preference panel and left only couple options left.

Changed in moblin-browser:
status: Confirmed → Fix Committed
Revision history for this message
zhangxu (xu-x-zhang) wrote :

Verified on 2008/03/11 image.

Changed in moblin-browser:
status: Fix Committed → Fix Released
zhangxu (xu-x-zhang)
Changed in moblin-browser:
status: Fix Released → New
Revision history for this message
Zhao Fan (fan-zhao) wrote :

Xu adds comment for the wrong bug. Sorry for confusion.

Jimmy, I am wondering why I can not see you fix in the image we created today :( Agree with you that the panel should be cleaned, and I think it should be as simple as possible. Moko even does not expose any interface for end-user to do configurations.

Bob, any suggestion on this?

Revision history for this message
Jimmy Huang (jimmyhuang-deactivatedaccount) wrote :

Fan,

I've checked in the fixes for it, but tagged it as UNRELEASED, so it wasn't being picked up the the build system. Once Carl integrates his fixes, and change it to gaston, then it will show up in the new image. I am sorry for the confusion, I shouldn't have changed the status to commited before Carl checks everything in.

I can actually completely remove the preference if you think it is appropriate, because I don't really thing a end user would really need to configure it. I only left some of the settings there just in case that a user might want to change the way how he can click on the webpage to do text-selection, and preference dialog actually gives some description of how to select and copy text while the panning addon is turned on.

Changed in moblin-browser:
status: New → Confirmed
Margie (margie-foster)
Changed in moblin-browser:
milestone: none → m10
Changed in moblin-browser:
status: Confirmed → Fix Committed
Revision history for this message
zhangxu (xu-x-zhang) wrote :

Verified on 2008/03/17 image.

Changed in moblin-browser:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.