'sort by bpm' in library doesn't

[Daniel Barlow]

In the Ubuntu binary packages of 1.6.0beta2, clicking on the 'BPM' column title seems to be sorting the tracks alphabetically not numerically. Or if that's not what it's doing, it's doing something non-obvious

95.3, 84.5, 82.7, 82.7, 79.3, 71.7, 312.2, 129.6, 127.2

I'll see if I can attach a screenshot

[Daniel Barlow (dan-telent)]

312.2 is a typo for 132.2, if you didn't guess

[Albert Santoni (gamegod)]

Thanks for the bug report Dan. I looked at trying to fix this a few weeks ago, and I thought it'd be a slam-dunk, but I couldn't find the place where the logic was incorrect. It looks like it might be lexicographically comparing the BPMs as strings as opposed to just comparing the floats...

Thanks,
Albert

[ironstorm (ironstorm-gmail)]

fix is in proxymodel.cpp - svn revision 1862

sort now behaves as follows (where 0.0 is no valid BPM detection data):
89.9, 123.0, 127.4, 0.0
127.4, 123.0, 89.9, 0.0

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issue/4923

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/4923