rbd_utils unit tests not running in gate

[melanie witt]

Awhile back, change:

https://review.opendev.org/c/openstack/nova/+/746904

moved rbd_utils out from the libvirt driver and into a central location under nova/storage. This move missed adding a __init__.py file under nova/tests/unit/storage, so unit test discovery wasn't picking up the rbd_utils tests and couldn't run them.

There was also a small bug introduced by change:

https://review.opendev.org/c/openstack/nova/+/574301

in RbdTestCase.setUp() that passed nonexistent self.images_rbd_pool to self.flags. It should be self.rbd_pool.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/790511

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/790511
Committed: https://opendev.org/openstack/nova/commit/8b647f1b3f56879be221b3925570790a1e0e77f8
Submitter: "Zuul (22348)"
Branch: master

commit 8b647f1b3f56879be221b3925570790a1e0e77f8
Author: melanie witt <email address hidden>
Date: Mon May 10 17:31:25 2021 +0000

    rbd: Get rbd_utils unit tests running again

    Awhile back, change I25baf5edd25d9e551686b7ed317a63fd778be533 moved
    rbd_utils out from the libvirt driver and into a central location under
    nova/storage. This move missed adding a __init__.py file under
    nova/tests/unit/storage, so unit test discovery wasn't picking up the
    rbd_utils tests and couldn't run them.

    This adds a __init__.py file under nova/tests/unit/storage to get the
    tests running again.

    This also fixes a small bug introduced by change
    I3032bbe6bd2d6acc9ba0f0cac4d00ed4b4464ceb in RbdTestCase.setUp() that
    passed nonexistent self.images_rbd_pool to self.flags. It should be
    self.rbd_pool.

    Closes-Bug: #1928007

    Change-Id: Ic03a5336abdced883f62f395690c0feac12075c8

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/790836

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/790836
Committed: https://opendev.org/openstack/nova/commit/8f018d754d5c55e432cd51df99278382b527283e
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 8f018d754d5c55e432cd51df99278382b527283e
Author: melanie witt <email address hidden>
Date: Mon May 10 17:31:25 2021 +0000

    rbd: Get rbd_utils unit tests running again

    Awhile back, change I25baf5edd25d9e551686b7ed317a63fd778be533 moved
    rbd_utils out from the libvirt driver and into a central location under
    nova/storage. This move missed adding a __init__.py file under
    nova/tests/unit/storage, so unit test discovery wasn't picking up the
    rbd_utils tests and couldn't run them.

    This adds a __init__.py file under nova/tests/unit/storage to get the
    tests running again.

    This also fixes a small bug introduced by change
    I3032bbe6bd2d6acc9ba0f0cac4d00ed4b4464ceb in RbdTestCase.setUp() that
    passed nonexistent self.images_rbd_pool to self.flags. It should be
    self.rbd_pool.

    Closes-Bug: #1928007

    Change-Id: Ic03a5336abdced883f62f395690c0feac12075c8
    (cherry picked from commit 8b647f1b3f56879be221b3925570790a1e0e77f8)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/794624

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/794624
Committed: https://opendev.org/openstack/nova/commit/04057099991579bccfb2accb6b0952ba589fe092
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 04057099991579bccfb2accb6b0952ba589fe092
Author: melanie witt <email address hidden>
Date: Mon May 10 17:31:25 2021 +0000

    rbd: Get rbd_utils unit tests running again

    Awhile back, change I25baf5edd25d9e551686b7ed317a63fd778be533 moved
    rbd_utils out from the libvirt driver and into a central location under
    nova/storage. This move missed adding a __init__.py file under
    nova/tests/unit/storage, so unit test discovery wasn't picking up the
    rbd_utils tests and couldn't run them.

    This adds a __init__.py file under nova/tests/unit/storage to get the
    tests running again.

    This also fixes a small bug introduced by change
    I3032bbe6bd2d6acc9ba0f0cac4d00ed4b4464ceb in RbdTestCase.setUp() that
    passed nonexistent self.images_rbd_pool to self.flags. It should be
    self.rbd_pool.

    Closes-Bug: #1928007

    Change-Id: Ic03a5336abdced883f62f395690c0feac12075c8
    (cherry picked from commit 8b647f1b3f56879be221b3925570790a1e0e77f8)
    (cherry picked from commit 8f018d754d5c55e432cd51df99278382b527283e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 23.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 22.2.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 24.0.0.0rc1 release candidate.