netapp driver should report home state to prevent scheduling on aggr not home

[Maurice Escher]

Hi,

during Netapp back end maintenance (in my case I've seen it on ontap upgrade and similar on hardware part replacement) no shares should be scheduled to the respective back end, because we know it will fail.

The error message already suggests a solution: don't schedule to an aggregate, which is not home.

See an example error: http://paste.openstack.org/show/805073/

I believe the Netapp driver can be extended to report that "is-home" state and the scheduler could respect it.

BR,
Maurice

[Goutham Pacha Ravi (gouthamr)]

Additional comments http://eavesdrop.openstack.org/meetings/manila/2021/manila.2021-05-13-15.00.log.html#l-91

[Maurice Escher (maurice-escher)]

I got a different stacktrace for the same problem:
https://paste.opendev.org/show/bRbzoxTJv53GHXzMt054/

When a node is not home, the node data ports list may no longer have matching ports.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/manila/+/841149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/manila/+/841149
Committed: https://opendev.org/openstack/manila/commit/d57c33d7a870924c3de6e4830d6facf71d47b098
Submitter: "Zuul (22348)"
Branch: master

commit d57c33d7a870924c3de6e4830d6facf71d47b098
Author: Felipe Rodrigues <email address hidden>
Date: Mon May 9 13:50:40 2022 -0300

    [NetApp] Fix lack of aggregate pool home state

    The NetApp driver is not reporting the home state of the aggregate
    pools. This information is useful during maintenance tasks, since
    not home aggregate cannot create shares.

    This patch adds to the report netapp capabilities the boolean
    `netapp_is_home`.

    Closes-Bug: #1927823
    Change-Id: I8e98541d8e457e9e4609410853b50d6156465f61

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/manila 18.0.0.0rc1 release candidate.