AIO-SX failed to come up due to sriov rate limit config failures in puppet

Bug #1927758 reported by Ghada Khalil
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
StarlingX
Fix Released
High
Steven Webster

Bug Description

Brief Description
------------------
AIO-SX node failed to come up after initial unlock due to sriov rate limit config failed in puppet manifest.

Severity
--------
Major

Steps to Reproduce
------------------
Install of lab with shared nic and sriov rate limit config

Expected Behavior
-----------------
Controller-0 to come up in enabled/available state

Actual Behavior
----------------
Controller failed

Reproducibility
---------------
Reproducible (100%)

System Configuration
---------------------
LAB:WFP1_2 (AIO-DX with shared NIC)

Branch/Pull Time/Commit
-----------------------
stx master: 2021-05-05_20-00-10

Last Pass
---------
stx master: 2021-04-06_09-56-20

Timestamp/Logs
--------------
The ratelimit stuff is being set by puppet before the PF is up. That is, before the apply_network_config.sh is run, which sets the # of VFs on the interface

2021-05-06T15:44:34.345 [[0;36mDebug: 2021-05-06 15:44:34 +0000 Exec[apply-network-config](provider=posix): Executing 'apply_network_config.sh'[[0m
2021-05-06T15:44:34.348 [[0;36mDebug: 2021-05-06 15:44:34 +0000 Executing: 'apply_network_config.sh'[[0m

2021-05-06T15:42:31.348 [[0;36mDebug: 2021-05-06 15:42:31 +0000 Exec[sriov-vf-rate-limit: 0000:18:04.2](provider=posix): Executing 'ip link set enp24s0f0 vf 18 max_tx_rate 200'[[0m
2021-05-06T15:42:31.351 [[0;36mDebug: 2021-05-06 15:42:31 +0000 Executing: 'ip link set enp24s0f0 vf 18 max_tx_rate 200'[[0m
2021-05-06T15:42:31.353 [[0;36mDebug: 2021-05-06 15:42:31 +0000 /Stage[main]/Platform::Interfaces::Sriov::Config/Platform::Interfaces::Sriov_vf_ratelimit[sriov0]/Platform::Interfaces::Sriov_ratelimit[0000:18:04.2]/Exec[sriov-vf-rate-limit: 0000:18:04.2]/returns: Sleeping for 1 seconds between tries[[0m

2021-05-06T15:44:35.000 controller-0 root: notice /usr/local/bin/apply_network_config.sh Bringing /var/run/network-scripts.puppet/ifcfg-enp24s0f1 up

Test Activity
-------------
Other-Lab install

Workaround
----------
N/A

CVE References

Ghada Khalil (gkhalil)
Changed in starlingx:
assignee: nobody → Steven Webster (swebster-wr)
Revision history for this message
Ghada Khalil (gkhalil) wrote :

screening: stx.6.0 / high - this issue is introduced/exposed by recent changes in stx master for https://bugs.launchpad.net/starlingx/+bug/1918139 No fix is required for the r/stx.5.0 branch

Changed in starlingx:
importance: Undecided → High
status: New → Triaged
tags: added: stx.6.0 stx.config stx.networking
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (master)

Fix proposed to branch: master
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/790300

Changed in starlingx:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (master)

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/790300
Committed: https://opendev.org/starlingx/stx-puppet/commit/97371409b9b2ae3f0db6a6a0acaeabd74927160e
Submitter: "Zuul (22348)"
Branch: master

commit 97371409b9b2ae3f0db6a6a0acaeabd74927160e
Author: Steven Webster <email address hidden>
Date: Fri May 7 15:33:43 2021 -0400

    Add SR-IOV rate-limit dependency

    Currently, the binding of an SR-IOV virtual function (VF) to a
    driver has a dependency on platform::networking. This is needed
    to ensure that SR-IOV is enabled (VFs created) before actually
    doing the bind.

    This dependency does not exist for configuring the VF rate-limits
    however. There is a chance that the VF rate-limiting configuration
    happens before the VFs are actually created.

    This commit fixes the issue by creating a dependency on
    platform::networking from the sriov::config class, which ensures
    the VFs are created before both driver binding and rate
    limiting configuration occurs.

    Closes-Bug: #1927758
    Signed-off-by: Steven Webster <email address hidden>
    Change-Id: Ic452247eb8c980e1b18bdc54832eb635d7a9fc54

Changed in starlingx:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792009

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-puppet (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792009

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-puppet (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792013

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792018

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on stx-puppet (f/centos8)

Change abandoned by "Chuck Short <email address hidden>" on branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792018

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to stx-puppet (f/centos8)

Fix proposed to branch: f/centos8
Review: https://review.opendev.org/c/starlingx/stx-puppet/+/792029

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to stx-puppet (f/centos8)
Download full text (48.0 KiB)

Reviewed: https://review.opendev.org/c/starlingx/stx-puppet/+/792029
Committed: https://opendev.org/starlingx/stx-puppet/commit/2b026190a3cb6d561b6ec4a46dfb3add67f1fa69
Submitter: "Zuul (22348)"
Branch: f/centos8

commit 3e3940824dfb830ebd39fd93265b983c6a22fc51
Author: Dan Voiculeasa <email address hidden>
Date: Thu May 13 18:03:45 2021 +0300

    Enable kubelet support for pod pid limit

    Enable limiting the number of pids inside of pods.

    Add a default value to protect against a missing value.
    Default to 750 pids limit to align with service parameter default
    value for most resource consuming StarlingX optional app (openstack).
    In fact any value above service parameter minimum value is good for the
    default.

    Closes-Bug: 1928353
    Signed-off-by: Dan Voiculeasa <email address hidden>
    Change-Id: I10c1684fe3145e0a46b011f8e87f7a23557ddd4a

commit 0c16d288fbc483103b7ba5dad7782e97f59f4e17
Author: Jessica Castelino <email address hidden>
Date: Tue May 11 10:21:57 2021 -0400

    Safe restart of the etcd SM service in etcd upgrade runtime class

    While upgrading the central cloud of a DC system, activation failed
    because there was an unexpected SWACT to controller-1. This was due
    to the etcd upgrade script. Part of this script runs the etcd
    manifest. This triggers a reload/restart of the etcd service. As this
    is done outside of the sm, sm saw the process failure and triggered
    the SWACT.

    This commit modifies platform::etcd::upgrade::runtime puppet class
    to do a safe restart of the etcd SM service and thus, solve the
    issue.

    Change-Id: I3381b6976114c77ee96028d7d96a00302ad865ec
    Signed-off-by: Jessica Castelino <email address hidden>
    Closes-Bug: 1928135

commit eec3008f600aeeb69a42338ed44332228a862d11
Author: Mihnea Saracin <email address hidden>
Date: Mon May 10 13:09:52 2021 +0300

    Serialize updates to global_filter in the AIO manifest

    Right now, looking at the aio manifest:
    https://review.opendev.org/c/starlingx/stx-puppet/+/780600/15/puppet-manifests/src/manifests/aio.pp
    there are 3 classes that update
    in parallel the lvm global_filter:
    - include ::platform::lvm::controller
    - include ::platform::worker::storage
    - include ::platform::lvm::compute
    And this generates some errors.

    We fix this by adding dependencies between the above classes
    in order to update the global_filter in a serial mode.

    Closes-Bug: 1927762
    Signed-off-by: Mihnea Saracin <email address hidden>
    Change-Id: If6971e520454cdef41138b2f29998c036d8307ff

commit 97371409b9b2ae3f0db6a6a0acaeabd74927160e
Author: Steven Webster <email address hidden>
Date: Fri May 7 15:33:43 2021 -0400

    Add SR-IOV rate-limit dependency

    Currently, the binding of an SR-IOV virtual function (VF) to a
    driver has a dependency on platform::networking. This is needed
    to ensure that SR-IOV is enabled (VFs created) before actually
    doing the bind.

    This dependency does not exist for configuring the VF rate-limits
    however. There is a cha...

tags: added: in-f-centos8
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.