Leaking username and backend in RBD driver

[Tobias Urdin]

The RBD utils get_pool_info() function raises an processutils.ProcessExecutionError from oslo.concurrency if it fails. That error message contains the Ceph username and the fact that it's running Ceph in the error message that a end-user can view.

| fault | {"code": 500, "created": "2021-05-03T14:00:57Z", "message": "Exceeded maximum number of retries. Exceeded max scheduling attempts 3 for instance 28c36a23-8e2b-4425-aeb3-502c536f43e8. Last exception: Unexpected error while running command. |
| | Command: ceph df --format=json --id openstack --conf /etc/ceph/ceph.conf

This information should not be available to end-users.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/nova/+/789374

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/789374
Committed: https://opendev.org/openstack/nova/commit/86af7feed06f08ddb3ef65122089216708d53a06
Submitter: "Zuul (22348)"
Branch: master

commit 86af7feed06f08ddb3ef65122089216708d53a06
Author: Tobias Urdin <email address hidden>
Date: Mon May 3 17:25:43 2021 +0200

    Stop leaking ceph df cmd in RBD utils

    If the ceph df command fails in the get_pool_info
    method of RBD utils the actual command executed
    if seen by the users in the fault error message.

    This hides the command behind a StorageError
    exception and logs the exception instead of leaking
    it to the users.

    Change-Id: I6e3a73f2e04d1a7636daf96d5af73c9cf2fbe220
    Closes-Bug: 1926978

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/nova/+/791938

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/nova/+/791939

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/791939
Committed: https://opendev.org/openstack/nova/commit/5ede75c65edbcb27557831ae6f5c3a9f81f23a0e
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5ede75c65edbcb27557831ae6f5c3a9f81f23a0e
Author: Tobias Urdin <email address hidden>
Date: Mon May 3 17:25:43 2021 +0200

    Stop leaking ceph df cmd in RBD utils

    If the ceph df command fails in the get_pool_info
    method of RBD utils the actual command executed
    if seen by the users in the fault error message.

    This hides the command behind a StorageError
    exception and logs the exception instead of leaking
    it to the users.

    Change-Id: I6e3a73f2e04d1a7636daf96d5af73c9cf2fbe220
    Closes-Bug: 1926978
    (cherry picked from commit 86af7feed06f08ddb3ef65122089216708d53a06)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/nova/+/791938
Committed: https://opendev.org/openstack/nova/commit/bec6dd475243b027ce5ca487e1a9bffdb866d25f
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit bec6dd475243b027ce5ca487e1a9bffdb866d25f
Author: Tobias Urdin <email address hidden>
Date: Mon May 3 17:25:43 2021 +0200

    Stop leaking ceph df cmd in RBD utils

    If the ceph df command fails in the get_pool_info
    method of RBD utils the actual command executed
    if seen by the users in the fault error message.

    This hides the command behind a StorageError
    exception and logs the exception instead of leaking
    it to the users.

    Change-Id: I6e3a73f2e04d1a7636daf96d5af73c9cf2fbe220
    Closes-Bug: 1926978
    (cherry picked from commit 86af7feed06f08ddb3ef65122089216708d53a06)
    (cherry picked from commit 5ede75c65edbcb27557831ae6f5c3a9f81f23a0e)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 23.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 22.2.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/nova 24.0.0.0rc1 release candidate.

[Tobias Urdin (tobias-urdin)]

edit: nop