[patch] Murrine GTK RGBA transparency support

Bug #192667 reported by Andrew Starr-Bochicchio
6
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
Wishlist
Mathias Brodala

Bug Description

The Murrine GTK engine now can use RGBA transparency. A patch has been written to allow Exaile to take advantage of this when using a GTK engine with RGBA support. See link bellow:

http://www.cimitan.com/murrine/node/96

Revision history for this message
Johannes Sasongko (sjohannes) wrote :

The patch still needs work because: (1) it hijacks the OSD code to modify the main window; (2) according to the description, it breaks the tray icon (whatever plugins add tray icons would also be broken).

To be honest I don't think changing every single app for this is a good idea. This kind of stuff needs to be done from GTK+. There's some discussion in http://bugzilla.gnome.org/show_bug.cgi?id=516885

Revision history for this message
Lucazade (lucazade) wrote : patch v0.2

Hi all!
I've released a new version of the RGBA patch for exaile (0.2.12b)

Changes:
- Fixed trayicon support
- OSD hijack no more needed!

http://www.cimitan.com/murrine/files/exaile_v02.patch.tar.bz2

let me know if ok.. i'm going to do a stress-test to see if it's fully working :)

Revision history for this message
Daniele Gramola (daniele-gramola) wrote :

Which file do I have to patch? I tried /usr/share/exaile/xl/gui/main.py but then exaile doesn't open...

Revision history for this message
Mathias Brodala (mathbr) wrote :

> Which file do I have to patch? I tried /usr/share/exaile/xl/gui/main.py
> but then exaile doesn't open...

Because the patch is outdated. A patch updated to the latest trunk (r1639) is attached.

Revision history for this message
Daniele Gramola (daniele-gramola) wrote :

It gives me an error: failed at 892...

Revision history for this message
Mathias Brodala (mathbr) wrote :

> It gives me an error: failed at 892...

Then you must be doing something wrong. It works just fine here:

$ bzr co lp:exaile exaile
You have not informed bzr of your launchpad login. If you are attempting a
write operation and it fails, run "bzr launchpad-login YOUR_ID" and try again.
$ cd exaile/
$ patch -p0 <../exaile_rgba_colormap.patch
patching file xl/gui/main.py
$

Revision history for this message
reacocard (reacocard) wrote :

patch no longer works against trunk.

Changed in exaile:
importance: Undecided → Wishlist
status: New → Incomplete
Revision history for this message
Johannes Sasongko (sjohannes) wrote :

I believe Mathias Brodala applied this as a hidden preference in 0.3.

Changed in exaile:
assignee: nobody → Mathias Brodala (mathbr)
milestone: none → 0.3.0
status: Incomplete → Fix Committed
reacocard (reacocard)
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.