Portfolio locking - replace duplicate code with lock_collection

Bug #1926382 reported by Doris Tam
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Doris Tam

Bug Description

Replace duplicate code

     // Lock the collection
        if ($view->get_collection()) {
            $collectionid = $view->get_collection()->get('id');
            execute_sql("UPDATE {collection} SET lock = 1 WHERE id = ?", array($collectionid));
        }

with the new function in lib/collection.php

Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11702

Changed in mahara:
milestone: none → 21.04.0
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11702
Committed: https://git.mahara.org/mahara/mahara/commit/10326d8c59e320c24d9011e47a21abf98be0557a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 10326d8c59e320c24d9011e47a21abf98be0557a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Feb 16 15:37:17 2021 +1300

Bug 1926382: Portfolio locking missing code

Change-Id: I7de1efc13696e4a92d4cd3410e908e201358016e

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11731

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11731
Committed: https://git.mahara.org/mahara/mahara/commit/75170b3191c7dcf2fd964918b31048050677fcc4
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_STABLE

commit 75170b3191c7dcf2fd964918b31048050677fcc4
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Feb 16 15:37:17 2021 +1300

Bug 1926382: Portfolio locking missing code

Change-Id: I7de1efc13696e4a92d4cd3410e908e201358016e
(cherry picked from commit 10326d8c59e320c24d9011e47a21abf98be0557a)

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11744

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.