Update doesn't refresh container configuration.

Bug #1926281 reported by Sofer Athlan-Guyot
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Critical
Sofer Athlan-Guyot

Bug Description

Hi,

discovered during testing of https://review.opendev.org/c/openstack/tripleo-heat-templates/+/788151/1/deployment/horizon/horizon-container-puppet.yaml#316

If you change the docker_config block, update won't refresh the container configuration on the overcloud and the change won't be taken into account. Here it's a mount point that will not be added.

The problem is that common_container_setup_tasks.yaml is not included during update, while that's where the tripleo_container_configs module is called.

Tags: upgrade
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)
Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/788690
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/1fd3ef688ca134a3922f681adcf5389579c8ff03
Submitter: "Zuul (22348)"
Branch: master

commit 1fd3ef688ca134a3922f681adcf5389579c8ff03
Author: Sofer Athlan-Guyot <email address hidden>
Date: Thu Apr 29 09:57:12 2021 +0200

    Make sure the container configuration is refreshed during update.

    Following the refactor from Idf004f7a13544dfc1a8a6da033debd1a4f8b96e7
    the operations needed to get the container configuration where removed
    from the step1 file.

    We need to re-include them explicitly during update so that new
    changes get taken into account.

    In the deployment we have this sequence (keeping only those common
    with update):
     - step-0
     - host-prep-task
     - common container setup
     - common deploy steps tasks 1-5

    We mimic this sequence in update by placing common container setup
    before the common deploy steps tasks 1-5.

    Change-Id: I5df88cf9d84f5fecb50b0c602b7923027d5f12b0
    Closes-Bug: 1926281

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 14.1.0

This issue was fixed in the openstack/tripleo-heat-templates 14.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.